Add method to return attn-mask for HF Tokenizer.#60
Open
cptspacemanspiff wants to merge 5 commits intomlc-ai:mainfrom
Open
Add method to return attn-mask for HF Tokenizer.#60cptspacemanspiff wants to merge 5 commits intomlc-ai:mainfrom
cptspacemanspiff wants to merge 5 commits intomlc-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I have been doing batched inference of things that use HF tokenizer. Your library is great, but does not expose the attention masks, which are useful when some of the inputs/outputs are padding.
This adds an additional tokenize method to the HF Tokenizer that returns both the token_ids and the attention masks.
It depends on my previous pull request, which separates out the hf cpp header declarations and the implementations.
#57