Warn when speculative decoding may hurt throughput for MoE models#1313
Open
Shylin26 wants to merge 2 commits into
Open
Warn when speculative decoding may hurt throughput for MoE models#1313Shylin26 wants to merge 2 commits into
Shylin26 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1132
Problem
When using
--draft-modelwith MoE target models (e.g. Qwen3.5-397B-A17B),speculative decoding can hurt throughput by 25-45% because the target model's
active parameter count is close to the draft model size, making draft+verify
more expensive than direct generation.
Solution
Added
_warn_speculative_moe()that runs after both models are loaded. It:num_expertsandnum_experts_per_tokin model config(num_experts_per_tok / num_experts) * total_paramsNon-MoE models are completely unaffected.