Skip to content

Add homogenization#65

Merged
mkofler96 merged 11 commits into
mainfrom
add-homogenization
Jun 18, 2026
Merged

Add homogenization#65
mkofler96 merged 11 commits into
mainfrom
add-homogenization

Conversation

@mkofler96

Copy link
Copy Markdown
Owner

No description provided.

mkofler96 added 3 commits May 26, 2026 09:54
- Introduced new experiment directory for testing homogenization.
- Added latest model, optimizer parameters, latent codes, and logs as binary files.
- Created specs.json to define network architecture and training parameters.
- Added training summary in training_summary.json.
- Implemented a test function to train the homogenization model in test_train_model.py.
Copilot AI review requested due to automatic review settings June 17, 2026 14:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@deepsource-io

deepsource-io Bot commented Jun 17, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in af6dea6...23969f1 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jun 18, 2026 9:22a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

mkofler96 and others added 8 commits June 18, 2026 08:59
The orientation check ran in float32 but torchfem evaluates Jacobians in
float64 (after verts.to(float64)). Tets with a tiny positive float32
volume can flip negative in float64, causing the "Negative Jacobian"
exception. Compute the final validity mask in float64 so the filter is
consistent with torchfem.
@mkofler96 mkofler96 merged commit 37c9f6b into main Jun 18, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants