Add homogenization#65
Merged
Merged
Conversation
- Introduced new experiment directory for testing homogenization. - Added latest model, optimizer parameters, latent codes, and logs as binary files. - Created specs.json to define network architecture and training parameters. - Added training summary in training_summary.json. - Implemented a test function to train the homogenization model in test_train_model.py.
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | Jun 18, 2026 9:22a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
for more information, see https://pre-commit.ci
The orientation check ran in float32 but torchfem evaluates Jacobians in float64 (after verts.to(float64)). Tets with a tiny positive float32 volume can flip negative in float64, causing the "Negative Jacobian" exception. Compute the final validity mask in float64 so the filter is consistent with torchfem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.