Skip to content

BUG: use prime dims for latent prior#483

Merged
mj-will merged 7 commits into
mainfrom
fix-prime-dims-bug
Jun 15, 2026
Merged

BUG: use prime dims for latent prior#483
mj-will merged 7 commits into
mainfrom
fix-prime-dims-bug

Conversation

@mj-will

@mj-will mj-will commented Jun 15, 2026

Copy link
Copy Markdown
Owner

prep_latent_prior was incorrectly using dims when constructing the draw function. This PR changes it to use the newly introduced prime_dims which replaces rescaled_dims

@mj-will mj-will added the bug Something isn't working label Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.46%. Comparing base (3a06ad6) to head (b12bcf8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   94.45%   94.46%           
=======================================
  Files          65       65           
  Lines        6823     6828    +5     
=======================================
+ Hits         6445     6450    +5     
  Misses        378      378           
Flag Coverage Δ
unittests 94.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mj-will mj-will added this to the 0.16.0 milestone Jun 15, 2026
@mj-will mj-will merged commit 6bd52cc into main Jun 15, 2026
35 checks passed
@mj-will mj-will deleted the fix-prime-dims-bug branch June 15, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant