dalli 4.x および 5.x のサポート#19
Draft
matsubara0507 wants to merge 5 commits into
Draft
Conversation
## Changes ### Dependency updates - Update dalli dependency from `~> 3.0` to `>= 3.0, < 6.0` - Update Ruby requirement from `>= 2.5` to `>= 3.1` - Update `.ruby-version` from 3.2.3 to 3.3.8 ### Test matrix improvements - Remove EOL Ruby versions (2.5, 2.6, 2.7, 3.0) - Add modern Ruby versions (3.3, 3.4) - Remove EOL ActiveSupport versions (5.2, 6.0) - Add current ActiveSupport versions (7.1, 7.2) - Add dalli version-specific tests (3.x, 4.x, 5.x) ### Test coverage - Total test combinations: 30 (4 Ruby × 8 gemfile - 2 excludes) - Excludes: dalli 5.x requires Ruby 3.3+ This update ensures compatibility with dalli 4.x and 5.x while maintaining backward compatibility with dalli 3.x, allowing users to upgrade dalli without breaking changes. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update TargetRubyVersion from 2.5 to 3.1 in .rubocop.yml - Fix gem order in dalli_*.gemfile (activesupport should come before dalli) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Dalli 4.x enforces that raw mode values must be strings. Integer values cause MarshalError: "Dalli raw mode requires string values, got: Integer" Changed all raw mode test fixtures from integers to strings to maintain compatibility with dalli 3.x, 4.x, and 5.x. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ActiveSupport 7.x changed the MemCacheStore initialization API, causing compatibility issues. Skip these tests when AS >= 7 to focus on Dalli::Client compatibility testing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ActiveSupport 6.1 is EOL and incompatible with Ruby 3.1+ due to Logger being removed from the standard library. Removed from both Appraisals and GitHub Actions workflow. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
このPRは、dalli 3.x との後方互換性を維持しながら、dalli 4.x および 5.x のサポートを追加します。
変更内容
依存関係の更新
~> 3.0から>= 3.0, < 6.0に変更>= 2.5から>= 3.1に変更.ruby-versionを 3.2.3 から 3.3.8 に更新テストマトリクスの改善
テストカバレッジ
テストの修正
背景
dalli 4.x には、以前はカスタムモンキーパッチでのみ利用可能だった
set_multiの upstream 実装が含まれています。これにより、ユーザーは破壊的変更なしに dalli 4.x にアップグレードできます。dalli 5.x は Ruby 3.3+ および memcached 1.6+ が必要で、binary protocol と SASL 認証のサポートが削除されています。
関連 Issue
https://github.com/monsterstrike/server/issues/35244 対応のために必要です。
🤖 Generated with Claude Code