mitogen: Fix sudo authentication with translated password prompt#1515
Closed
moreati wants to merge 1 commit into
Closed
mitogen: Fix sudo authentication with translated password prompt#1515moreati wants to merge 1 commit into
moreati wants to merge 1 commit into
Conversation
moreati
force-pushed
the
issue1514
branch
2 times, most recently
from
be41449 to
ec10738
Compare
Translated prompts may contain whitespace, which was being ignored because mitogen.sudo.PASSWORD_PROMPT_RE is now parsed as VERBOSE. In turn this wasn't caught because there was no test coverage.
Member
Author
|
Superceded by #1516 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translated prompts may contain whitespace, which was being ignored because mitogen.sudo.PASSWORD_PROMPT_RE is now parsed as VERBOSE. In turn this wasn't caught because there was no test coverage.
Fixes #1514