This repository was archived by the owner on Dec 19, 2017. It is now read-only.
Support MFA token from AWS config file#225
Closed
radeksimko wants to merge 1 commit into
Closed
Conversation
|
#208 already out there and waiting... |
Author
|
@gnethercutt Ah, sorry for being blind here! 🤦 btw. AFAIK Mitchell & Hashicorp are now mostly focusing on adopting the official AWS library: https://github.com/hashicorp/aws-sdk-go which is IMO why it's relatively quiet here. |
|
No worries, it was mostly a shameless attempt at a bump without calling it that. :) |
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's already a support for the MFA token through ENV variables, so this simple change is adding support for the same from config files.
Have a look to http://blogs.aws.amazon.com/security/post/Tx3D6U6WSFGOK2H/A-New-and-Standardized-Way-to-Manage-Credentials-in-the-AWS-SDKs
just to confirm correctness of variable name according to Amazon's practices.