This repository was archived by the owner on Dec 19, 2017. It is now read-only.
Refresh authentication tokens when they expire#183
Open
abustany wants to merge 2 commits into
Open
Conversation
Inspired from crowdmob/goamz.
libc
pushed a commit
to libc/goamz
that referenced
this pull request
Jan 8, 2015
Fix - DeleteSnapshots takes a single snapshot id per request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the Auth API slightly to fix token refresh when using the AWS instance metadata service to fetch credentials.
If breaking the API is an issue, Auth.token could be switch back to public, but then there's the risk of some parts of the code using the field directly instead of the method.
Right now, errors when reloading are ignored. One could add an error to the return values of Token() if that's considered an issue.