fix: remove broken and unused imports in LangGraph codestral notebook#246
Open
yaowubarbara wants to merge 1 commit intomistralai:mainfrom
Open
fix: remove broken and unused imports in LangGraph codestral notebook#246yaowubarbara wants to merge 1 commit intomistralai:mainfrom
yaowubarbara wants to merge 1 commit intomistralai:mainfrom
Conversation
- Remove broken `from langchain_core.pydantic_v1 import BaseModel, Field` (module removed in recent langchain-core versions) - Remove unused `ChatPromptTemplate` import and `code_gen_prompt_claude` variable - Remove other unused imports: `itemgetter`, `RunnablePassthrough`, `PromptTemplate` Fixes mistralai#232, fixes mistralai#231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232, fixes #231
Changes
The
langgraph_code_assistant_mistral.ipynbnotebook had several import issues:Broken import (Codestral with self-correction : Failed import of pydantic v1 #232):
from langchain_core.pydantic_v1 import BaseModel, Fieldfails becausepydantic_v1was removed in recentlangchain-coreversions.BaseModelandFieldare already correctly imported frompydanticearlier in the notebook, so this line is both broken and redundant.Unused code (Codestral with self-correction - ChatPromptTemplate.from_messages not used #231):
ChatPromptTemplatewas imported and used to createcode_gen_prompt_claude, but this variable is never referenced anywhere else in the notebook.Other unused imports:
itemgetter,RunnablePassthrough, andPromptTemplateare imported but never used.All removals confirmed to not affect notebook execution (verified against the code flow).