fix some warnings and add .zip release#24
Closed
ClaudioDaffra wants to merge 3 commits intomist64:masterfrom
Closed
fix some warnings and add .zip release#24ClaudioDaffra wants to merge 3 commits intomist64:masterfrom
ClaudioDaffra wants to merge 3 commits intomist64:masterfrom
Conversation
Owner
|
Thanks for taking the time to contribute! I appreciate the effort to clean up warnings. However, I'd prefer to fix the warnings at their source rather than suppressing them with #pragma GCC diagnostic ignored across entire files. The fopen cast is a good catch though. I'd also rather not include compiled binaries in the repo — users who need a build can compile from source, or binaries could be attached to a GitHub release instead. Going to close this for now, but thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed some warnings during the compilation and included a zip file with the compilation of Visual Studio 2022 and GCC, the latest versions