Skip to content

revert(backend): revert compile-config#17411

Open
kakkokari-gtyih wants to merge 9 commits into
misskey-dev:developfrom
kakkokari-gtyih:revert-compile-config
Open

revert(backend): revert compile-config#17411
kakkokari-gtyih wants to merge 9 commits into
misskey-dev:developfrom
kakkokari-gtyih:revert-compile-config

Conversation

@kakkokari-gtyih

@kakkokari-gtyih kakkokari-gtyih commented May 15, 2026

Copy link
Copy Markdown
Member

What

Why

Fix #17407
Fix #17075

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 24.87%. Comparing base (81b1824) to head (35d54f4).

Files with missing lines Patch % Lines
packages/backend/src/config.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17411      +/-   ##
===========================================
- Coverage    25.23%   24.87%   -0.37%     
===========================================
  Files         1163     1161       -2     
  Lines        39842    39628     -214     
  Branches     11083    11042      -41     
===========================================
- Hits         10055     9858     -197     
+ Misses       23868    23849      -19     
- Partials      5919     5921       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 304.85 MB 322.40 MB +17.54 MB +5.75%
VmHWM 304.85 MB 322.40 MB +17.54 MB +5.75%
VmSize 23170.27 MB 23169.40 MB -0.86 MB 0%
VmData 1370.79 MB 1369.64 MB -1.15 MB -0.08%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 305.07 MB 322.43 MB +17.35 MB +5.69%
VmHWM 305.07 MB 322.43 MB +17.35 MB +5.69%
VmSize 23170.35 MB 23169.65 MB -0.70 MB 0%
VmData 1370.88 MB 1369.89 MB -0.98 MB -0.07%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 305.48 MB 322.83 MB +17.35 MB +5.68%
VmHWM 305.48 MB 322.83 MB +17.35 MB +5.68%
VmSize 23170.35 MB 23169.65 MB -0.70 MB 0%
VmData 1370.96 MB 1369.89 MB -1.06 MB -0.07%

⚠️ Warning: Memory usage has increased by more than 5%. Please verify this is not an unintended change.

See workflow logs for details

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review May 15, 2026 08:44
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 15, 2026
@anatawa12 anatawa12 linked an issue May 15, 2026 that may be closed by this pull request
1 task
@anatawa12

Copy link
Copy Markdown
Member

17075 リンクしました

@kakkokari-gtyih

Copy link
Copy Markdown
Member Author

👀

@kakkokari-gtyih

Copy link
Copy Markdown
Member Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

compile-config の廃止提案 Add environment variable for JSON config

2 participants