Skip to content

Remove logging completely for unregistered cnight operations#1324

Merged
chrispalaskas merged 6 commits intomainfrom
fix/remove-logs-for-cnight-observations-of-enterprise-addresses
Apr 16, 2026
Merged

Remove logging completely for unregistered cnight operations#1324
chrispalaskas merged 6 commits intomainfrom
fix/remove-logs-for-cnight-observations-of-enterprise-addresses

Conversation

@chrispalaskas
Copy link
Copy Markdown
Contributor

@chrispalaskas chrispalaskas commented Apr 13, 2026

Log Who triggers it

1 has no delegation part Non-base Cardano addresses — enterprise (addr1w…), pointer, reward. These cannot register for DUST by construction.
2 No valid dust registration Base addresses (payment + stake) whose reward address has not posted a DUST registration on Midnight. These users could register but haven't.
3 No create event for UTXO Spend of a UTXO whose create was dropped — i.e., the owner was unregistered at create time (the downstream of #2). Also fires if UtxoOwners was pruned, though that shouldn't happen in normal flow.

A middle ground for #2 and #3 would be demoting to log::trace!
which is what was done.

Overview

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: chrispalaskas <chris.palaskas@gmail.com>
@chrispalaskas chrispalaskas requested a review from a team as a code owner April 13, 2026 20:28
Signed-off-by: chrispalaskas <chris.palaskas@gmail.com>
Signed-off-by: chrispalaskas <chris.palaskas@gmail.com>
…ddresses' of https://github.com/midnightntwrk/midnight-node into fix/remove-logs-for-cnight-observations-of-enterprise-addresses

Signed-off-by: chrispalaskas <chris.palaskas@gmail.com>
@chrispalaskas chrispalaskas enabled auto-merge April 15, 2026 23:00
@chrispalaskas chrispalaskas added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 3295373 Apr 16, 2026
33 checks passed
@chrispalaskas chrispalaskas deleted the fix/remove-logs-for-cnight-observations-of-enterprise-addresses branch April 16, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants