Fix ArgumentNullException in EchoBot when joining via short Teams meeting URL#859
Draft
Copilot wants to merge 2 commits intosasthana/fix-short-teams-url-parsingfrom
Draft
Fix ArgumentNullException in EchoBot when joining via short Teams meeting URL#859Copilot wants to merge 2 commits intosasthana/fix-short-teams-url-parsingfrom
Copilot wants to merge 2 commits intosasthana/fix-short-teams-url-parsingfrom
Conversation
…vice For short Teams meeting URLs, JoinInfo.ParseJoinURL returns an empty ChatInfo with a null ThreadId. This caused an ArgumentNullException in JoinCallAsync (used as ConcurrentDictionary key) and potential NullReferenceExceptions in CallsOnUpdated. Changes to BotService.cs: - JoinCallAsync: only perform duplicate-call check when ThreadId is non-null/empty; short URL joins proceed directly to AddAsync - CallsOnUpdated: use null-conditional ChatInfo access and fall back to call.Id when ThreadId is absent, ensuring handlers are always stored and removed with a valid non-null key Co-authored-by: samarthasthana <3836631+samarthasthana@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for short Teams meeting URLs
Fix ArgumentNullException in EchoBot when joining via short Teams meeting URL
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JoinInfo.ParseJoinURLreturns an emptyChatInfo(nullThreadId) for short URLs (https://teams.microsoft.com/meet/<id>?p=<passcode>).BotServiceusedChatInfo.ThreadIddirectly as aConcurrentDictionarykey, throwingArgumentNullExceptionon every short URL join attempt.Changes —
BotService.csJoinCallAsync: Guard duplicate-call check against nullThreadId; short URL joins skip the pre-join check and proceed directly toAddAsyncCallsOnUpdated: Usecall.Resource.ChatInfo?.ThreadId ?? call.Idas the tracking key so handlers are always stored/removed with a valid non-null key✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.