Conversation
riverar
approved these changes
Jun 28, 2024
ChrisDenton
approved these changes
Jun 28, 2024
Collaborator
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
This sounds like a good balance. Having support tightly scoped to only the essentials on non-Windows platforms still allows other parties to build on top of that if they wish. Just in a way that doesn't negatively impact windows-rs support for Windows.
sivadeilra
approved these changes
Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-rs project is focused on bringing the best of Windows to Rust developers. Various efforts to support non-Windows targets continue to make it too difficult to support Windows, which is the whole point of this project.
The position we're taking is to provide basic non-Windows compatibility for
windows-coreonly to support COM and nothing more. Even this adds regrettable complexity to thewindows-corecrate, but this update at least attempts to make that complexity manageable by providing a simple way for us to partition what parts ofwindows-coreis specific to Windows and what is cross-platform. Subsequent updates will limit more of the code that isn't required for COM support.The test_linux crate covers what little support we offer for non-Windows targets. This is limited to
windows-coreandwindows-resultand is tested in linux.yml as part of each build.Fixes: #3101
Fixes: #3083
Related: #3125