Skip to content

Remove redundant trimming in connection string wizard steps#512

Draft
Copilot wants to merge 2 commits intodev/tnaum/connection-string-handlingfrom
copilot/sub-pr-511
Draft

Remove redundant trimming in connection string wizard steps#512
Copilot wants to merge 2 commits intodev/tnaum/connection-string-handlingfrom
copilot/sub-pr-511

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

Addresses review feedback to remove redundant .trim() calls that were trimming connection strings immediately after they were already trimmed from showInputBox().

Changes

  • PromptMongoRUEmulatorConnectionStringStep.ts: Removed duplicate trim of context.connectionString after assignment
  • PromptConnectionStringStep.ts: Removed intermediate trimmedConnectionString variable; use newConnectionString directly
// Before
const newConnectionString = (await context.ui.showInputBox({...})).trim();
const trimmedConnectionString = newConnectionString.trim();  // Redundant
const parsed = new DocumentDBConnectionString(trimmedConnectionString);

// After
const newConnectionString = (await context.ui.showInputBox({...})).trim();
const parsed = new DocumentDBConnectionString(newConnectionString);

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on trimming in connection string handling PR Remove redundant trimming in connection string wizard steps Feb 18, 2026
Copilot AI requested a review from tnaum-ms February 18, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments