Draft
Conversation
bwateratmsft
commented
Feb 11, 2026
Contributor
Author
There was a problem hiding this comment.
TODO: Probably version this as an alpha
Contributor
Author
There was a problem hiding this comment.
Revert changes to this file
Contributor
Author
There was a problem hiding this comment.
Revert this file
| description: "Allows for read, write and delete access to Azure Storage blob containers and data", | ||
| roleType: "BuiltInRole" | ||
| } as RoleDefinition, | ||
| } as const, |
Contributor
Author
There was a problem hiding this comment.
These changes make it so the full values and everything show up in the declarations. Otherwise it just does export declare const ....
| export * from './wizard/StorageAccountNameStep'; | ||
| export * from './wizard/UserAssignedIdentityCreateStep'; | ||
| export * from './wizard/UserAssignedIdentityListStep'; | ||
| export * from './wizard/UserAssignedIdentityNameStep'; |
Contributor
Author
There was a problem hiding this comment.
I guess this was never actually exported? Need to check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been annoying since forever, and would be part of the work toward #1349.
Consider the old
index.d.ts:Details
Compared to a rollup of the new declarations (provided by
@microsoft/api-extractor):Details
Copilot assures me that there are only a couple of maybe breaking changes.
Breaking Signature Changes
1.
RoleAssignmentExecuteStep— type parameters removedindex.d.ts:RoleAssignmentExecuteStep<T extends IResourceGroupWizardContext, TKey extends keyof T>RoleAssignmentExecuteStep(no type parameters; uses concreteIResourceGroupWizardContext & Partial<ExecuteActivityContext>)<T, TKey>will get a compile error.2.
AzureAccountTreeItemBase.getSubscriptionPromptStep— stricter parameterindex.d.ts:wizardContext: Partial<ISubscriptionActionContext>context: Partial<ISubscriptionActionContext> & IActionContextIActionContext-compatible object will break.3.
AzureAccountTreeItemBaseconstructor — narrowertestAccounttypeindex.d.ts:testAccount?: {}testAccount?: AzureAccountExtensionApi4.
createAzureSubscriptionClient— generic constraint addedindex.d.ts:<T><T extends ServiceClient>ServiceClient.Base Class Changes
5.
StorageAccountCreateStep— base class widenedindex.d.ts:extends AzureWizardExecuteStepextends AzureWizardExecuteStepWithActivityOutputAzureWizardExecuteStepWithActivityOutputextendsAzureWizardExecuteStep, but subclasses may now need to implement additional abstract methods.6.
UserAssignedIdentityCreateStep— same base class change as aboveStructural Changes
7.
RoleDefinitionsItem— changed from type alias to classindex.d.ts: SimpletypewithgetChildren,getTreeItem,idclasswith a specific constructor and many more propertiesRoleDefinitionsItemobjects as plain objects will break (though the docs say to usecreateRoleDefinitionsItemsinstead).Additions in Generated (non-breaking but notable)
createResourcesClient,createSubscriptionsClient— new functionsuiUtils.listAll,uiUtils.IPartialList— present in generated, missing fromindex.d.tsUserAssignedIdentityListStep.getSubWizard— new public methodResourceGroupListStepconstructor(suppressCreate?: boolean)now visibleResourceGroupVerifyStep.createFailOutput,ResourceGroupCreateStep.createFailOutput— new public methodsRoleAssignmentExecuteStep.addExecuteSteps— new public methodRoleDefinitionsTreeItem.contextValue(static + instance) — now declaredAzureAccountExtensionApi,AzureSession,AzureSubscription,CloudShell,UploadOptions, etc.) — newly exported