-
Notifications
You must be signed in to change notification settings - Fork 334
Add backward compatibility support for constructor accessibility on abstract base types #9484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+198
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JonathanCrd <17486462+JonathanCrd@users.noreply.github.com>
Co-authored-by: JonathanCrd <17486462+JonathanCrd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix backward compatibility for public constructors
Add backward compatibility support for missing public constructors
Jan 28, 2026
packages/http-client-csharp/generator/docs/backward-compatibility.md
Outdated
Show resolved
Hide resolved
Instead of generating additional constructors, only change the modifier from private protected to public on abstract base types when the last contract had a public constructor with matching parameters. This is a simpler and more targeted approach. Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copilot
AI
changed the title
Add backward compatibility support for missing public constructors
Add backward compatibility support for constructor accessibility on abstract base types
Jan 28, 2026
jorgerangel-msft
approved these changes
Jan 28, 2026
Contributor
|
No changes needing a change description found. |
jorgerangel-msft
approved these changes
Jan 28, 2026
Contributor
|
Fixes #9483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Regenerating SDKs from TypeSpec (previously from autorest) changes constructor accessibility on abstract base types, breaking existing code. Example from Azure.Search.Documents:
Previous (autorest):
Current (TypeSpec without fix):
Changes
Core Implementation
private protectedtopublicon abstract base types when the last contract had a public constructor with matching parametersApproach
This implementation changes the accessibility modifier on existing constructors rather than generating new ones. It only applies when:
private protectedconstructor with matching parameters (same count, types, and names)Generated Code
Testing
BackCompat_AbstractTypeConstructorAccessibilitytest that verifies constructor modifiers change fromprivate protectedtopublicOriginal prompt
This section details on the original issue you should resolve
<issue_title>[Bug]: Backward Compatibility not generating pre-existing public constructors</issue_title>
<issue_description>### Describe the bug
Pre-existing public constructors should not be missing from the generated code. This should be another Back Compat scenario. See Backward Compatibility Support for more details.
Generating Azure.Search.Documents have the issue where a public constructor is missing, for instance, this is what the previously generated code from autorest looks like:
and the new generated model looks like: