Skip to content

Fix unknown scalar constructors crashing openapi3 #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timotheeguerin merged 6 commits into from
Jan 29, 2026
Merged

Fix unknown scalar constructors crashing openapi3 #9475

timotheeguerin merged 6 commits into from
Jan 29, 2026
+147 −13

Conversation

@timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jan 27, 2026

fix #9394

@microsoft-github-policy-service microsoft-github-policy-service bot added compiler:core Issues for @typespec/compiler emitter:openapi3 Issues for @typespec/openapi3 emitter labels Jan 27, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 27, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/compiler@9475

npm i https://pkg.pr.new/microsoft/typespec/@typespec/openapi@9475

npm i https://pkg.pr.new/microsoft/typespec/@typespec/openapi3@9475

commit: 14f42e4

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/openapi3
Show changes

@typespec/openapi3 - fix ✏️

Handle use of .now() constructor on date time types in examples and default.

@typespec/compiler - feature ✏️

[API] serializeValueAsJson throws a UnsupportedScalarConstructorError for unsupported scalar constructor instead of crashing

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 27, 2026 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin marked this pull request as ready for review January 29, 2026 18:16
@timotheeguerin timotheeguerin added this pull request to the merge queue Jan 29, 2026
Merged via the queue into microsoft:main with commit a255931 Jan 29, 2026
29 checks passed
@timotheeguerin timotheeguerin deleted the fix/unknown-scalar-constructors branch January 29, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

Assignees

No one assigned

Labels

compiler:core Issues for @typespec/compiler emitter:openapi3 Issues for @typespec/openapi3 emitter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Emitter "@typespec/openapi3" crashes when using Date.now() as query string default value.

3 participants

@timotheeguerin @azure-sdk @markcowl