Fixture testdatapath, refactor and unify testdatapath handling #147
+159
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d usage: - pytest fixture (adding code and info to conftest.py) - compute the testdata_path in only one place - provide used test files as constants
…d usage: - to non test code we shall discuss wether testdata makes sense at all - here i have implemented a small workaround with reusage of conftest.py via a wrapper
Collaborator
|
Contributor
Author
oops, they should not be in extra subdir. Sorry, my fault. It meant to be /tests only.
yes. I always feel bad when i do suppressions to hide hacks or workarounds like that. Will remove it.
passing explicit is a good idea, let me try that. (explicit is better than implicit ;-) |
- removed dependency on tests aka conftest.py - added explicit arguments for passing in testdata and validation logic
- adopted conftest.py to use only parent instaed of parent.parent
…t the subprocess needs the full environment (PATH, PYTHONPATH, system libraries, etc.) to import Python modules correctly. Fix: Changed the fixture to inherit the full parent environment (dict(os.environ)) instead of building a minimal one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a possible solution for #146
for details/question of implementation approach, please check #146