Skip to content

Conversation

@bmerkle
Copy link
Contributor

@bmerkle bmerkle commented Jan 1, 2026

  • moved demo to examples/demo
  • moved gmail to tools/gmail
  • moved spec to docs/spec later we can delete/update outdated code/doc etc
  • adjusted make and config files, ci, gitignore
  • adjusted links in documentation
  • removed unused import in simple_query_demo.py

fix part3+4 for #125

- moved demo to examples/demo
- moved samples to examples/samples
- moved gmail to tools/gmail
- moved spec to docs/spec
later we can delete/update outdated code/doc etc

- adopted make and config files, ci, gitignore
- adopted links in documentation
- removed usused import in simple_query_demo.py
@gvanrossum gvanrossum changed the title 125-examples: move demos/sample/etc to examples: 125-examples: move demos to examples, spec to docs/spec Jan 1, 2026
@gvanrossum gvanrossum changed the title 125-examples: move demos to examples, spec to docs/spec 125-examples: move various ancillary dirs into subdirs Jan 1, 2026
@bmerkle
Copy link
Contributor Author

bmerkle commented Jan 1, 2026

uv run pyright src tests tools gmail
it is failing because there is still gmail in that line (it should be "examples"

strange i do not have any line like this in my commit ?

@gvanrossum
Copy link
Collaborator

uv run pyright src tests tools gmail

it is failing because there is still gmail in that line (it should be "examples"

strange i do not have any line like this in my commit ?

This is because CI uses ci.yml from the main branch, always.

@gvanrossum
Copy link
Collaborator

As I said, CI fails because it is using the old ci.yml from main. Please ignore the CI.

@bmerkle just fix the .gitignore and then I'll approve and merge.

I have an idea to make this a less frequent issue: we can put the list of folders to check and format in e.g. sources.txt file, and put in ci.yml something like uv run pyright $(cat sources.txt) and uv run black <flags> $(cat sources) -- the sources.txt file will come from the checked-out branch. But I'm not sure if Windows supports that syntax. :-( Anyway, if we were to do this we should do it later in a separate PR.

@bmerkle
Copy link
Contributor Author

bmerkle commented Jan 1, 2026

@bmerkle just fix the .gitignore and then I'll approve and merge.

have you made review for .gitignore ? i do not see a comment or requested changes in github UI
whats need to be fixed ?

.gitignore Outdated
Comment on lines 33 to 34
/examples/testdata/Episode_53_Answer_results.json
/examples/testdata/Episode_53_Search_results.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be /tests/ instead of /examples/

@gvanrossum
Copy link
Collaborator

gvanrossum commented Jan 1, 2026

@bmerkle just fix the .gitignore and then I'll approve and merge.

have you made review for .gitignore ? i do not see a comment or requested changes in github UI whats need to be fixed ?

Sorry I did it on my phone which failed to send the comment. Redid it now. /examples/testdata/ should be /tests/testdata/.

@gvanrossum
Copy link
Collaborator

Oh, looks like test_mcp.py is failing because it references a file in testdata, which was moved.

@bmerkle
Copy link
Contributor Author

bmerkle commented Jan 1, 2026

Oh, looks like test_mcp.py is failing because it references a file in testdata, which was moved.

right, should be fixed now. Currently the path are kind of hardcoded and we have some code duplication.
I think it makes sense to introduce a small utility method to have one place where we compute the test location files.

Copy link
Collaborator

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@gvanrossum gvanrossum merged commit baa699d into microsoft:main Jan 1, 2026
2 of 3 checks passed
@gvanrossum
Copy link
Collaborator

I think it makes sense to introduce a small utility method to have one place where we compute the test location files.

Maybe a fixture that computes the path of testdata? Or even several for the paths of commonly used test data files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants