Skip to content

Docker customization#747

Open
clarked-msft wants to merge 4 commits intomicrosoft:Developmentfrom
clarked-msft:docker-customization
Open

Docker customization#747
clarked-msft wants to merge 4 commits intomicrosoft:Developmentfrom
clarked-msft:docker-customization

Conversation

@clarked-msft
Copy link
Contributor

Fix problems with customizing CA and pip.conf from testing in customer environment.

Copilot AI review requested due to automatic review settings February 27, 2026 19:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a documented and build-time mechanism to customize Docker trust (custom CA certs) and Python package installation behavior (pip.conf) for customer environments.

Changes:

  • Copy docker-customization/pip.conf into the builder image as /etc/pip.conf for pip configuration during pip install.
  • Copy docker-customization/custom-ca-certificates/ into the system trust anchors and run update-ca-trust during the build.
  • Add docs and release notes entry describing the customization workflow.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 6 comments.

File Description
application/single_app/Dockerfile Uses repo-root docker-customization/ inputs to configure pip and CA trust; adds runtime cert-related env vars.
docker-customization/pip.conf Placeholder pip config file intended to be customized by deployers/customers.
docs/how-to/docker_customization.md New how-to documentation for adding custom CA certs and pip.conf.
docs/explanation/release_notes.md Adds a release note entry for Docker customization fixes.

Comment on lines +5 to +9
Add custom certification authorities to [/docker-customization/custom-ca-certificates](/docker-customization/custom-ca-certificates/) and they will be pull in to the system CAs during docker build. Must be in .crt format.

## Custom pip conf

Add customization as needed to [/docker-customization/pip.conf](/docker-customization/pip.conf). This will be used during docker build. No newline at end of file
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links use absolute site paths like /docker-customization/..., but docker-customization/ lives at the repo root (not under docs/) so these links will likely 404 in the rendered docs site. Consider linking to the GitHub paths (or describe the filesystem paths without markdown links) so readers can actually find the files.

Suggested change
Add custom certification authorities to [/docker-customization/custom-ca-certificates](/docker-customization/custom-ca-certificates/) and they will be pull in to the system CAs during docker build. Must be in .crt format.
## Custom pip conf
Add customization as needed to [/docker-customization/pip.conf](/docker-customization/pip.conf). This will be used during docker build.
Add custom certification authorities to the `docker-customization/custom-ca-certificates/` directory in the repository root, and they will be pulled into the system CAs during docker build. Must be in `.crt` format.
## Custom pip conf
Add customization as needed to the `docker-customization/pip.conf` file in the repository root. This will be used during docker build.

Copilot uses AI. Check for mistakes.

## Custom Certificate Authorities

Add custom certification authorities to [/docker-customization/custom-ca-certificates](/docker-customization/custom-ca-certificates/) and they will be pull in to the system CAs during docker build. Must be in .crt format.
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: “they will be pull in to the system CAs” should be rephrased (e.g., “they will be pulled into the system trust store”) to read correctly.

Suggested change
Add custom certification authorities to [/docker-customization/custom-ca-certificates](/docker-customization/custom-ca-certificates/) and they will be pull in to the system CAs during docker build. Must be in .crt format.
Add custom certification authorities to [/docker-customization/custom-ca-certificates](/docker-customization/custom-ca-certificates/), and they will be pulled into the system trust store during the Docker build. Must be in .crt format.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 27, 2026 19:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

Comment on lines +93 to +96
* **Docker Customization: CA Certificate and pip.conf**
* Fixed Docker customization issues related to custom CA certificate handling and `pip.conf` configuration.
* Ensures Python package installation works reliably in environments requiring custom certificate trust and pip configuration.
* (Ref: Docker customization, CA cert setup, `pip.conf` handling)
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a new behavior/doc and a release-notes entry under v0.238.024, but application/single_app/config.py still defines VERSION = "0.238.024". If this is intended to ship as a new patch, bump the third segment in config.py and add the release-notes entry under the new version header to keep versioning consistent.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@Bionic711 Bionic711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants