Skip to content

test: reduce flakiness in a few tests #40200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Apr 14, 2026
+24 −44
Merged

test: reduce flakiness in a few tests #40200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/library/capabilities.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ it('should play audio @smoke', async ({ page, server, browserName, platform }) =
await page.goto(server.EMPTY_PAGE);
await page.setContent(`<audio src="${server.PREFIX}/example.mp3"></audio>`);
await page.$eval('audio', e => e.play());
await page.waitForTimeout(1000);
await page.waitForTimeout(3000);
await page.$eval('audio', e => e.pause());
expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.2);
expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.1);
});

it('should support webgl @smoke', async ({ page }) => {
Expand Down
40 changes: 22 additions & 18 deletions tests/library/chromium/extensions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,28 +56,32 @@ it.describe('MV3', () => {
const page = await context.newPage();
const cdp = await context.newCDPSession(page);

let versionId: string | undefined;
let scopeURL: string | undefined;
let runningStatus: string | undefined;
cdp.on('ServiceWorker.workerVersionUpdated', ({ versions }: any) => {
const v = versions[0];
if (!v)
return;
versionId = v.versionId;
runningStatus = v.runningStatus;
});
cdp.on('ServiceWorker.workerRegistrationUpdated', ({ registrations }: any) => {
if (registrations.length)
scopeURL = registrations[0].scopeURL;
});
const waitForCdpEvent = <T>(event: string, predicate: (params: any) => T | undefined): Promise<T> => {
return new Promise<T>(resolve => {
const handler = (params: any) => {
const result = predicate(params);
if (result !== undefined) {
cdp.off(event as any, handler);
resolve(result);
}
};
cdp.on(event as any, handler);
});
};

const versionPromise = waitForCdpEvent('ServiceWorker.workerVersionUpdated', ({ versions }: any) => versions[0]?.versionId as string | undefined);
const scopePromise = waitForCdpEvent('ServiceWorker.workerRegistrationUpdated', ({ registrations }: any) => registrations[0]?.scopeURL as string | undefined);
await cdp.send('ServiceWorker.enable');
await expect.poll(() => versionId && scopeURL, { timeout: 5000 }).toBeTruthy();
const versionId = await versionPromise;
const scopeURL = await scopePromise;

const stoppedPromise = waitForCdpEvent('ServiceWorker.workerVersionUpdated', ({ versions }: any) => versions[0]?.runningStatus === 'stopped' ? true : undefined);
await cdp.send('ServiceWorker.stopWorker', { versionId });
// Wait for full stop before triggering restart.
await expect.poll(() => runningStatus, { timeout: 5000 }).toBe('stopped');
await stoppedPromise;

const runningPromise = waitForCdpEvent('ServiceWorker.workerVersionUpdated', ({ versions }: any) => versions[0]?.runningStatus === 'running' ? true : undefined);
await cdp.send('ServiceWorker.startWorker', { scopeURL });
await expect.poll(() => runningStatus, { timeout: 5000 }).toBe('running');
await runningPromise;

const startTime2 = await sw1.evaluate(() => (globalThis as any).startTime);
expect(startTime2).toBeGreaterThan(startTime1);
Expand Down
24 changes: 0 additions & 24 deletions tests/playwright-test/ui-mode-test-network-tab.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,30 +456,6 @@ test('should copy network request', async ({ runUITest, server }) => {
});


test('should not preserve selection across test runs', async ({ runUITest, server }) => {
const { page } = await runUITest({
'network-tab.test.ts': `
import { test, expect } from '@playwright/test';
test('network tab test', async ({ page }) => {
await page.goto('${server.PREFIX}/network-tab/network.html');
});
`,
});

await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');

await page.getByRole('tab', { name: 'Network' }).click();
await page.getByRole('listitem').filter({ hasText: 'network.html' }).click();
const headersPanel = page.getByRole('tabpanel', { name: 'Headers' });
await expect(headersPanel).toBeVisible();

await page.getByRole('treeitem', { name: 'network tab test' }).dblclick();
await expect(headersPanel).toBeHidden();
await expect(page.getByTestId('workbench-run-status')).toContainText('Passed');
await expect(headersPanel).toBeHidden();
});

test('should preserve selection during test run', async ({ runUITest, server }, testInfo) => {
const { page } = await runUITest({
'network-tab.test.ts': `
Expand Down
Loading