Skip to content

feat(test-runner): error when overriding non-option fixture in config#40197

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:feat-fixture-override-error
Apr 14, 2026
Merged

feat(test-runner): error when overriding non-option fixture in config#40197
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:feat-fixture-override-error

Conversation

@dgozman
Copy link
Copy Markdown
Collaborator

@dgozman dgozman commented Apr 14, 2026

Summary

  • Setting a non-option fixture in a project's use section used to be silently ignored. Emit a load-time error pointing the user at { option: true } or test.extend().
  • Unknown keys and option overrides remain unaffected.

Setting a non-option fixture in a project's `use` section was silently
ignored, leaving users wondering why their override had no effect. Emit
a load-time error pointing at the right approach (test.extend, or
declaring the fixture with { option: true }).
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-test.spec.ts:23 › debug test and snapshot @mcp-windows-latest

5973 passed, 916 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:361 › reuse launch › should work with routeWebSocket `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:776 › run-server › should upload a folder `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:812 › should update state on subsequent run `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:812 › should update state on subsequent run `@windows-latest-node20`

39181 passed, 847 skipped


Merge workflow run.

@dgozman dgozman merged commit c45f472 into microsoft:main Apr 14, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants