chore(build): fix esbuild bundle warnings and externals

packages/playwright-core/src/browserServerImpl.ts

@@ -29,7 +29,6 @@ import { ProgressController } from './server/progress';
 import type { BrowserServer, BrowserServerLauncher } from './client/browserType';
 import type { LaunchServerOptions, Logger } from './client/types';
 import type { ProtocolLogger } from './server/types';
-import type { EventEmitter as WebSocketEventEmitter } from 'events';
 import type { Browser } from './server/browser';
 
 export class BrowserServerLauncherImpl implements BrowserServerLauncher {
@@ -86,7 +85,7 @@ export class BrowserServerLauncherImpl implements BrowserServerLauncher {
     const wsEndpoint = await server.listen(options.port, options.host);
 
     // 3. Return the BrowserServer interface
-    const browserServer = new EventEmitter() as (BrowserServer & WebSocketEventEmitter);
+    const browserServer = new EventEmitter() as (BrowserServer & EventEmitter);
     browserServer.process = () => browser.options.browserProcess.process!;
     browserServer.wsEndpoint = () => wsEndpoint;
     browserServer.close = () => browser.options.browserProcess.close();

packages/playwright/src/common/configLoader.ts

@@ -128,7 +128,8 @@ export async function loadConfig(location: ConfigLocation, overrides?: ConfigCLI
   // 3. Load transform options from the playwright config.
   const babelPlugins = (userConfig as any)['@playwright/test']?.babelPlugins || [];
   const external = userConfig.build?.external || [];
-  setTransformConfig({ babelPlugins, external });
+  const jsxImportSource = path.dirname(require.resolve('playwright'));
+  setTransformConfig({ babelPlugins, external, jsxImportSource });
   if (!overrides?.tsconfig)
     setSingleTSConfig(fullConfig?.singleTSConfigPath);
 

packages/playwright/src/transform/babelBundle.ts

@@ -14,8 +14,6 @@
  * limitations under the License.
  */
 
-import path from 'path';
-
 import * as babel from '@babel/core';
 import traverseFunction from '@babel/traverse';
 
@@ -32,9 +30,9 @@ export type { NodePath, PluginObj, types as T } from '@babel/core';
 export type { BabelAPI } from '@babel/helper-plugin-utils';
 
 export type BabelPlugin = [string, any?];
-export type BabelTransformFunction = (code: string, filename: string, isModule: boolean, pluginsPrefix: BabelPlugin[], pluginsSuffix: BabelPlugin[]) => BabelFileResult | null;
+export type BabelTransformFunction = (code: string, filename: string, isModule: boolean, pluginsPrefix: BabelPlugin[], pluginsSuffix: BabelPlugin[], jsxImportSource?: string) => BabelFileResult | null;
 
-function babelTransformOptions(isTypeScript: boolean, isModule: boolean, pluginsPrologue: [string, any?][], pluginsEpilogue: [string, any?][]): TransformOptions {
+function babelTransformOptions(isTypeScript: boolean, isModule: boolean, pluginsPrologue: [string, any?][], pluginsEpilogue: [string, any?][], jsxImportSource?: string): TransformOptions {
   const plugins = [
     [require('@babel/plugin-syntax-import-attributes'), { deprecatedAssertSyntax: true }],
   ];
@@ -77,7 +75,7 @@ function babelTransformOptions(isTypeScript: boolean, isModule: boolean, plugins
   plugins.push([require('@babel/plugin-transform-react-jsx'), {
     throwIfNamespace: false,
     runtime: 'automatic',
-    importSource: path.dirname(require.resolve('playwright')),
+    ...(jsxImportSource ? { importSource: jsxImportSource } : {}),
   }]);
 
   if (!isModule) {
@@ -126,14 +124,14 @@ function isTypeScript(filename: string) {
   return filename.endsWith('.ts') || filename.endsWith('.tsx') || filename.endsWith('.mts') || filename.endsWith('.cts');
 }
 
-export function babelTransform(code: string, filename: string, isModule: boolean, pluginsPrologue: [string, any?][], pluginsEpilogue: [string, any?][]): BabelFileResult | null {
+export function babelTransform(code: string, filename: string, isModule: boolean, pluginsPrologue: [string, any?][], pluginsEpilogue: [string, any?][], jsxImportSource?: string): BabelFileResult | null {
   if (isTransforming)
     return null;
 
   // Prevent reentry while requiring plugins lazily.
   isTransforming = true;
   try {
-    const options = babelTransformOptions(isTypeScript(filename), isModule, pluginsPrologue, pluginsEpilogue);
+    const options = babelTransformOptions(isTypeScript(filename), isModule, pluginsPrologue, pluginsEpilogue, jsxImportSource);
     return babel.transform(code, { filename, ...options });
   } finally {
     isTransforming = false;

packages/playwright/src/transform/transform.ts

@@ -46,6 +46,7 @@ const cachedTSConfigs = new Map<string, ParsedTsConfigData[]>();
 export type TransformConfig = {
   babelPlugins: [string, any?][];
   external: string[];
+  jsxImportSource?: string;
 };
 
 let _transformConfig: TransformConfig = {
@@ -248,7 +249,7 @@ export function transformHook(originalCode: string, filename: string, moduleUrl?
     name,
     { ...(opts || {}), setTransformData: setTransformDataForPlugin },
   ]);
-  const babelResult = babelTransform(originalCode, filename, !!moduleUrl, wrappedPrologue, pluginsEpilogue);
+  const babelResult = babelTransform(originalCode, filename, !!moduleUrl, wrappedPrologue, pluginsEpilogue, _transformConfig.jsxImportSource);
   if (!babelResult?.code)
     return { code: originalCode, serializedCache };
   const { code, map } = babelResult;

utils/build/build.js

@@ -280,10 +280,18 @@ class EsbuildStep extends Step {
     super({ concurrent: false });
     this._options = options;
     this._watchPaths = watchPaths;
-    // For bundled outputs we always want a metafile so we can emit a
-    // sidecar .bundle.txt report next to each output.
-    if (options.bundle && !options.metafile)
-      options.metafile = true;
+    if (options.bundle) {
+      // For bundled outputs we always want a metafile so we can emit a
+      // sidecar report next to each output.
+      if (!options.metafile)
+        options.metafile = true;
+      // Suppress direct-eval warnings — Playwright intentionally uses eval
+      // in evaluate() callbacks that get stringified and sent to the browser.
+      if (!options.logOverride)
+        options.logOverride = {};
+      if (!options.logOverride['direct-eval'])
+        options.logOverride['direct-eval'] = 'silent';
+    }
   }
 
   /** @override */
@@ -739,10 +747,12 @@ steps.push(new EsbuildStep({
   external: [
     'playwright-core',
     'playwright-core/*',
+    'playwright',
     '../globals',
     '../package',
     '../utils',
     '../matchers/expect',
+    '../transform/esmLoader.js',
   ],
   plugins: [dynamicImportToRequirePlugin],
 }, [filePath('packages/playwright/src')]));
@@ -766,6 +776,7 @@ steps.push(new EsbuildStep({
     '../loader/loaderProcessEntry.js',
     '../worker/workerProcessEntry.js',
     '../transform/babelBundle',
+    '../transform/esmLoader',
   ],
   plugins: [dynamicImportToRequirePlugin],
 }, [filePath('packages/playwright/src')]));
@@ -787,6 +798,7 @@ steps.push(new EsbuildStep({
     '../globals',
     '../package',
     '../util',
+    '../transform/esmLoader',
   ],
   plugins: [dynamicImportToRequirePlugin],
 }, [filePath('packages/playwright/src')]));
@@ -809,6 +821,7 @@ steps.push(new EsbuildStep({
     '../package',
     '../utils',
     '../matchers/expect',
+    '../transform/esmLoader',
   ],
   plugins: [dynamicImportToRequirePlugin],
 }, [filePath('packages/playwright/src')]));