Fix mypy error caused by requests 2.34.1 HeadersType change#143
Closed
fpfp100 wants to merge 1 commit into
Closed
Conversation
requests 2.34.1 changed HeadersType from Mapping[str, str | bytes] to MutableMapping[str, str | bytes], which causes mypy to reject dict[str, str] due to MutableMapping's invariant value type parameter. Update the _post_with_retries signature to match the new expected type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fpfp100
requested review from
JacksonWeber,
MSNev,
ajmfehr,
biswapm,
gwharris7,
hectorhdzg,
jeremydvoss,
lzchen,
nikhilNava,
rads-1996 and
sellakumaran
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve a mypy type-checking failure introduced by requests==2.34.1 changing its header type alias to use MutableMapping[str, str | bytes], by updating the internal _post_with_retries helper to accept the new header type.
Changes:
- Import
MutableMappingfor typing fromcollections.abc. - Update
_post_with_retries(..., headers=...)to acceptMutableMapping[str, str | bytes].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return text | ||
|
|
||
| def _post_with_retries(self, url: str, body: str, headers: dict[str, str]) -> bool: | ||
| def _post_with_retries(self, url: str, body: str, headers: MutableMapping[str, str | bytes]) -> bool: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requests2.34.1 changedHeadersTypefromMapping[str, str | bytes]toMutableMapping[str, str | bytes], which causes mypy to rejectdict[str, str]due toMutableMapping's invariant value type parameter._post_with_retriessignature to useMutableMapping[str, str | bytes]to match the new type.Test plan
Black, Pylint, and Mypyjob)🤖 Generated with Claude Code