Revert: Fix getCallerBaggagePairs userId fallback#140
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Reverts the previous user.id fallback behavior so telemetry only uses aadObjectId (GUID) for user.id, aligning with ingest requirements and preventing downstream scenarios from receiving non-AAD identifiers.
Changes:
- Update
getCallerBaggagePairsto setuser.idonly fromfrom.aadObjectId. - Remove unit tests that asserted fallback behavior to
agenticUserId/from.id. - Remove
from.idfrom theActivityLiketype definition.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/internal/unit/a365/hosting/turnContextUtils.test.ts | Removes tests that validated the reverted fallback chain behavior. |
| src/a365/hosting/types.ts | Updates activity typing by removing from.id. |
| src/a365/hosting/turnContextUtils.ts | Enforces user.id to come only from aadObjectId. |
| .claude/settings.local.json | Adds Claude local settings with allowed tool permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacksonWeber
approved these changes
May 13, 2026
alexlu4250
approved these changes
May 13, 2026
hectorhdzg
approved these changes
May 13, 2026
alexlu4250
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #116.
The ingest service only accepts GUIDs for
user.id. Any non-GUID value gets replaced with an all-zeros GUID (00000000-0000-0000-0000-000000000000). Allowing non-GUID values as userId (via theaadObjectId → agenticUserId → from.idfallback chain) breaks downstream scenarios that expect an AAD object ID.Test plan
🤖 Generated with Claude Code
Note
The original PR will not take effect since UPN (non-GUID) values are always ignored by the ingestion service.