Update telemetry SDK name to microsoft-opentelemetry#134
Merged
Conversation
Change TELEMETRY_SDK_NAME_VALUE from 'A365ObservabilitySDK' to 'microsoft-opentelemetry' to align with the package distribution name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nikhilNava
requested review from
JacksonWeber,
MSNev,
ajmfehr,
biswapm,
fpfp100,
gwharris7,
hectorhdzg,
jeremydvoss,
lzchen,
rads-1996 and
sellakumaran
as code owners
This was referenced May 12, 2026
Merged
JacksonWeber
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the A365-specific telemetry.sdk.name value used when enriching A365 spans, changing it from a baseline-specific identifier (A365ObservabilitySDK) to the distro/product identifier (microsoft-opentelemetry) to align with the package distribution naming.
Changes:
- Update
OpenTelemetryConstants.TELEMETRY_SDK_NAME_VALUEtomicrosoft-opentelemetryfor A365 span enrichment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+137
to
139
| public static readonly TELEMETRY_SDK_NAME_VALUE = "microsoft-opentelemetry"; | ||
| public static readonly TELEMETRY_SDK_LANGUAGE_VALUE = "nodejs"; | ||
| public static readonly TELEMETRY_SDK_VERSION_VALUE = MICROSOFT_OPENTELEMETRY_VERSION; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
TELEMETRY_SDK_NAME_VALUEfromA365ObservabilitySDKtomicrosoft-opentelemetryto align with the package distribution name.Sibling PRs: