Add missing attribute array validation for TreeEnsembleClassifier#27571
Merged
Add missing attribute array validation for TreeEnsembleClassifier#27571
Conversation
…EnsembleClassifier
yuslepukhin
reviewed
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens TreeEnsembleAttributesV3 parsing for TreeEnsembleClassifier by applying the same attribute-array size validations previously only enforced on the regressor path, preventing potential out-of-bounds access from malformed ONNX models.
Changes:
- Move
ORT_ENFORCEsize/consistency checks to apply to both classifier and regressor attribute parsing. - Add negative tests ensuring malformed classifier models (mismatched node/class attribute arrays) fail during initialization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| onnxruntime/test/providers/cpu/ml/tree_ensembler_classifier_test.cc | Adds regression tests that expect failure when classifier attribute arrays are mismatched. |
| onnxruntime/core/providers/cpu/ml/tree_ensemble_attribute.h | Applies existing attribute array validation checks to classifier path as well as regressor path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onnxruntime/test/providers/cpu/ml/tree_ensembler_classifier_test.cc
Outdated
Show resolved
Hide resolved
onnxruntime/test/providers/cpu/ml/tree_ensembler_classifier_test.cc
Outdated
Show resolved
Hide resolved
yuslepukhin
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
TreeEnsembleAttributesV3constructor intree_ensemble_attribute.hhad 15ORT_ENFORCEsize-validation checks in the regressor path but none in the classifier path. A malformed ONNX model with mismatchedTreeEnsembleClassifierattribute arrays (e.g.,class_idsvsclass_nodeids) could cause out-of-bounds access.To fix this, moved all
ORT_ENFORCEvalidation checks out of theelse(regressor) branch so they apply to both classifier and regressor paths.