Split Nemo specific speech features into a separate header#1061
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the shared speech feature headers to decouple NeMo-specific kernels from the broader speech_features.hpp header (which pulls in dlib), enabling consumers to use NemoLogMel and PerFeatureNormalize without the dlib dependency while keeping backward compatibility.
Changes:
- Added
shared/api/nemo_speech_features.hppcontainingNemoLogMelandPerFeatureNormalize. - Updated
shared/api/speech_features.hppto include the new header and removed the inlined NeMo kernel definitions from it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| shared/api/speech_features.hpp | Re-includes the new NeMo-only header and removes the embedded NeMo kernel implementations. |
| shared/api/nemo_speech_features.hpp | New header that exposes NeMo speech kernels without including dlib headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sayanshaw24
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the NeMo speech feature kernels (NemoLogMel, PerFeatureNormalize) into a new header so consumers can use them without pulling in dlib. The original header still re-includes the new one, so it remains backward-compatible.