Skip to content

Conversation

@devm33
Copy link
Contributor

@devm33 devm33 commented Jan 1, 2026

This PR adds running the GitHub Actions CI on the cross-architecture compiled builds.

The added CI caught an issue that the cross-compiled build was not correctly using the sysroot and linking against the wrong GLIBC version. Installing the correct cross-compilation toolchain fixes that.

Also fixes a duplicate trailing slash here:

const dir = `${r}/${d}/`;

Used here:
let helperPath = native.dir + '/spawn-helper';

follow up to #853
cc #851

@devm33 devm33 force-pushed the xarch-ci branch 5 times, most recently from 489cbe7 to b6b7991 Compare January 2, 2026 03:40
@devm33 devm33 marked this pull request as ready for review January 2, 2026 04:51
@devm33
Copy link
Contributor Author

devm33 commented Jan 2, 2026

Closing to edit PR title

@devm33 devm33 closed this Jan 2, 2026
@lydell
Copy link
Contributor

lydell commented Jan 2, 2026

FYI it’s possible to edit the PR title: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request (That link is about changing base branch, but changing the title is the same UI flow.)

@devm33
Copy link
Contributor Author

devm33 commented Jan 2, 2026

FYI it’s possible to edit the PR title: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request (That link is about changing base branch, but changing the title is the same UI flow.)

Unfortunately, that requires write access to the repo which I don't have for this repo:
Screenshot 2026-01-02 at 10 03 57

Updated PR is here: #857

@lydell
Copy link
Contributor

lydell commented Jan 2, 2026

Huh, that’s strange. The Edit button is there for me, and it works, but I don’t have write access to this repo. Oh well.

@devm33
Copy link
Contributor Author

devm33 commented Jan 2, 2026

Huh, that’s strange. The Edit button is there for me, and it works, but I don’t have write access to this repo. Oh well.

Oh weird I must be in some sort of extra-not-allowed ACL 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants