Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage ? 43.99%
=======================================
Files ? 59
Lines ? 7108
Branches ? 2011
=======================================
Hits ? 3127
Misses ? 3937
Partials ? 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2c8314a to
99568e5
Compare
Add the SysCallLib instance for OneCryptoLoaderSupvMm when using MmSupervisorPkg BaseLibSysCall so library resolution succeeds. Update OneCryptoBinSupvMm to consume gMmRing3HandlerReadyProtocol and add MmSupervisorPkg.dec so the protocol GUID resolves. Signed-off-by: Doug Flick
Update OneCryptoPkg DSC library mappings to use MsCorePkg/Library/FltUsedLib/FltUsedLib.inf after the FltUsedLib move from MdePkg. Signed-off-by: Doug Flick <dougflick@microsoft.com>
Update OpensslPkg DSC library mapping to use MsCorePkg/Library/FltUsedLib/FltUsedLib.inf after the FltUsedLib move from MdePkg. Signed-off-by: Doug Flick <dougflick@microsoft.com>
Update MbedTlsPkg DSC library mapping to use MsCorePkg/Library/FltUsedLib/FltUsedLib.inf after the FltUsedLib move from MdePkg. Signed-off-by: Doug Flick <dougflick@microsoft.com>
Pin MU_BASECORE, Features/MM_SUPV, and Common/MU to specific commits in both PlatformBuild and CI settings to avoid floating branch drift in local and CI setup flows. Signed-off-by: Doug Flick <dougflick@microsoft.com>
Add UnitTestHostTlsLib.inf, a HOST_APPLICATION wrapper for the production TlsLib sources, enabling TlsLib to be linked into host-based unit test executables. Update OpensslPkgHostUnitTest.dsc with TlsLib and IntrinsicLib library mappings and the TlsLibUnitTestHost component reference for the provider-agnostic TLS unit tests in CryptoPkg. Signed-off-by: Doug Flick <dougflick@microsoft.com>
Temporary dependency change for development. Points MU_BASECORE to flickdm/mu_basecore feat/TlsLibUnitTest branch which contains the TlsLib host-based unit tests. Drop this commit once the TlsLib tests are merged into microsoft/mu_basecore release/202511. Signed-off-by: Doug Flick <dougflick@microsoft.com>
99568e5 to
29efeb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for host-based unit testing of the
TlsLiblibrary and updates the dependency onmu_basecoreto a feature branch. The main changes include introducing a new INF file for the host-basedTlsLib, updating the DSC configuration to include this library and its tests, and adjusting dependencies to use a development branch with TLS unit test support.Dependency updates:
MU_BASECOREdependency in both.pytool/CISettings.pyandPlatformBuild.pyto use thefeat/TlsLibUnitTestbranch fromflickdm/mu_basecore.gitinstead of the Microsoft mainline branch.TlsLib host unit test support:
UnitTestHostTlsLib.inf, which wraps the productionTlsLibsources for use in host-based unit tests. This setsMODULE_TYPEtoHOST_APPLICATIONand specifies the relevant source files and dependencies.OpensslPkgHostUnitTest.dscto includeUnitTestHostTlsLib.infas the implementation for theTlsLiblibrary class, and added required library classes for host-based testing.TestTlsLibHost.inf) in the DSC file, which enumerates cipher suites and TLS capabilities for host-based testing.How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>