FIX: Remove return in finally that swallows exceptions (#417)#526
Merged
Conversation
Simplify _check_jsonfield_supported_sqlite() to return directly from try/except instead of using a variable with return in finally. The finally-return pattern silently swallows all exceptions including KeyboardInterrupt and other BaseExceptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test helper in testapp to avoid the Python anti-pattern of returning from a finally block, which would otherwise swallow in-flight exceptions (including BaseException subclasses like KeyboardInterrupt). This aligns the test suite with correct exception propagation behavior while keeping the helper’s intent (detecting SQLite JSON function support) unchanged.
Changes:
- Refactored
_check_jsonfield_supported_sqlite()to returnTrue/Falsedirectly from thetry/exceptblocks. - Removed the
finally: return ...pattern that suppressed unexpected exceptions during the support check.
jahnvi480
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #417
Simplify
_check_jsonfield_supported_sqlite()to return directly fromtry/exceptinstead of using a variable withreturninfinally.The
finally-return pattern silently swallows all exceptions includingKeyboardInterruptand otherBaseExceptionsubclasses.Test-only change, no production code affected.