Skip to content

Update base.py #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OctaOmega wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Update base.py #520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27dff96
Update base.py
OctaOmega Apr 12, 2026
93ef931
Merge branch 'dev' into dev
bewithgaurav May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions mssql/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def _build_connection_string(self, conn_params, driver):
user = conn_params.get('USER', None)
password = conn_params.get('PASSWORD', None)
port = conn_params.get('PORT', None)
trusted_connection = conn_params.get('Trusted_Connection', 'yes')
trusted_connection = conn_params.get('Trusted_Connection', None)

options = conn_params.get('OPTIONS', {})
dsn = options.get('dsn', None)
Expand Down Expand Up @@ -345,10 +345,18 @@ def _build_connection_string(self, conn_params, driver):
cstr_parts['PWD'] = password
elif 'TOKEN' not in conn_params:
if ms_drivers.match(driver) and 'Authentication=ActiveDirectoryMsi' not in options_extra_params:
cstr_parts['Trusted_Connection'] = trusted_connection
# Do not implicitly force Windows authentication.
# Only include Trusted_Connection when explicitly configured.
if trusted_connection is not None:
cstr_parts['Trusted_Connection'] = trusted_connection
else:
cstr_parts['Integrated Security'] = 'SSPI'

# Preserve legacy behavior for non-Microsoft drivers.
# For Microsoft drivers, avoid injecting an authentication mode
# unless explicitly requested through USER/PASSWORD, TOKEN,
# or Trusted_Connection.
if not ms_drivers.match(driver):
cstr_parts['Integrated Security'] = 'SSPI'

cstr_parts['DATABASE'] = database

if ms_drivers.match(driver) and os.name == 'nt':
Expand Down
Loading