CHORE: Added tests for subtraction of DateTime fields (#368)#472
Conversation
fixed with same methodology as in django ticket microsoft#368
|
@PawelKawula - thanks for raising this fix! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Convert lhs_params/rhs_params to tuples early to prevent TypeError when compiler.compile() returns mixed list/tuple param types - Remove redundant tuple() calls in both DateField and else branches - Add comment explaining the normalization - Add 8 unit tests covering: both-tuples, both-lists, mixed list+tuple, empty params, DateField path, and DateTimeField path
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hey @PawelKawula - thanks for the detailed bug report on #368 and for putting this fix together - great catch on the mixed list/tuple params issue. Heads up: we already included the core we'd love to merge this for the test coverage. Before we can, the CLA bot needs you to agree to the Contributor License Agreement - requesting you to please reply to the bot's comment above with: Once that's done we'll get this merged. Thanks again :) |
|
@microsoft-github-policy-service agree |
bewithgaurav
changed the title
3 participants
This pull request fixes issue #368
More details about the fix can be found in django ticket here
https://code.djangoproject.com/ticket/31133