Support multi-node in MemoryChannel tutorial
#726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chhwang
requested review from
Binyang2014,
caiomcbr,
Copilot,
mahdiehghazim and
seagater
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the MemoryChannel tutorial to support multi-node execution in addition to the existing single-node multi-process mode. The changes enable users to run the tutorial example across different physical nodes using command-line arguments.
Changes:
- Modified the
workerfunction to accept rank, GPU ID, and bootstrap IP:port as parameters instead of deriving rank from GPU ID - Updated
mainfunction to support both single-node (no arguments) and multi-node (3 arguments) execution modes - Enhanced documentation to explain cross-node execution with MNNVL hardware support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| examples/tutorials/03-memory-channel/bidir_memory_channel.cu | Refactored to support command-line arguments for multi-node execution while maintaining backward compatibility for single-node mode |
| docs/tutorials/03-memory-channel.md | Added new section explaining cross-node execution with usage examples |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.