Skip to content

Fix ToggleableColumnBuilder.WithHierarchicalToggle #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmaxson-ms merged 2 commits into from
Mar 9, 2026
Merged

Fix ToggleableColumnBuilder.WithHierarchicalToggle #433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebc728
Empty
Mar 9, 2026
fa464fd
Fix WithHierarchicalToggle
Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Microsoft.Performance.SDK.Runtime/ColumnBuilding/Builders/ToggledColumnBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation.
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

using System;
Expand Down Expand Up @@ -69,7 +69,7 @@ public override ToggleableColumnBuilder WithToggle<T>(
new DataColumn<T>(
new ColumnConfiguration(this.baseColumn.Configuration)
{
Metadata = new ColumnMetadata(this.baseColumn.Configuration.Metadata) { Name = toggleDescriptor.Properties.ColumnName ?? this.baseColumn.Configuration.Metadata.Name},
Metadata = new ColumnMetadata(this.baseColumn.Configuration.Metadata) { Name = toggleDescriptor.Properties.ColumnName ?? this.baseColumn.Configuration.Metadata.Name },
},
projection))
).ToList(),
Expand All @@ -88,17 +88,17 @@ public override ToggleableColumnBuilder WithHierarchicalToggle<T>(
Guard.NotNull(collectionProvider, nameof(collectionProvider));

return new ToggledColumnBuilder(
[
this.toggles.Append(
new AddedToggle(
toggleDescriptor,
new HierarchicalDataColumn<T>(
new ColumnConfiguration(this.baseColumn.Configuration)
{
Metadata = new ColumnMetadata(this.baseColumn.Configuration.Metadata) { Name = toggleDescriptor.Properties.ColumnName ?? this.baseColumn.Configuration.Metadata.Name},
Metadata = new ColumnMetadata(this.baseColumn.Configuration.Metadata) { Name = toggleDescriptor.Properties.ColumnName ?? this.baseColumn.Configuration.Metadata.Name },
},
projection,
collectionProvider)),
],
collectionProvider))
).ToList(),
baseColumn,
processor);
}
Expand Down
Loading