Update ICU to 78 - Part 6: build and CI plumbing#187
Open
aoruganti-msft wants to merge 5 commits into
Open
Conversation
UWP projects (common_uwp, i18n_uwp, makedata_uwp) failed to build on Visual Studio 2026 (BuildToolVersion=18.0) with: Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.0.0 was not found. Root cause: Build.Windows.PlatformToolset.props had toolset mappings only for VS 14.0/15.0/16.0/17.0 (v140/v141/v142/v143). On VS 18.0 no AutoDetectedPlatformToolset matched, so PlatformToolset fell through. The subsequent latest-SDK alias block at line 39 was conditioned on PlatformToolset == v142|v143 and did not fire, leaving WindowsTargetPlatformVersion unset. VS 18 UWP Default.props (.../Application Type/Windows Store/10.0/Default.props) then assigned the sentinel value 10.0.0.0 to WindowsTargetPlatformVersion, which is not a real installed SDK, producing MSB8036. Fix: add VS 18.0 -> v145 mapping and include v145 in the latest-SDK alias condition. With this change, building UWP projects on VS 18 resolves WindowsTargetPlatformVersion to the literal "10.0" alias, which VC targets dynamically resolve to the latest installed Windows 10 SDK via _LatestWindowsTargetPlatformVersion (no hard-coded SDK number; works on any host with a Windows 10 SDK installed). Verified: - common_uwp.vcxproj Release|x64: exit 0, common_uwp.dll produced - i18n_uwp.vcxproj Release|x64: exit 0, i18n_uwp.dll produced - makedata_uwp via allinone.sln Release|x64: exit 0, icudt78.dll produced in bin64UWP/, testdata built Diagnosis verified by independent gpt-5.5 DA pass (cited primary sources: VS UWP Default.props line 27-32, Microsoft.Cpp.WindowsSDK.props line 124). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Build.Windows.ProjectConfiguration.props had hardcoded SDK pinning for ARM and ARM64 desktop configs: L66, L70: <WindowsTargetPlatformVersion>10.0.22621.0</WindowsTargetPlatformVersion> L188, L204: <AdditionalLibraryDirectories>...Windows Kits\10\Lib\10.0.22621.0\um\arm[64]</AdditionalLibraryDirectories> x86/x64 do not pin a specific SDK; they inherit the latest-installed "10.0" alias from Build.Windows.PlatformToolset.props (lines 32-43). ARM/ARM64 had been pinned since 2020 when Windows 10 SDK was required explicitly for desktop ARM but default desktop SDK was Win 8.1; later upgrades migrated x86/x64 to the dynamic alias but the ARM/ARM64 hardcode stayed, only being bumped (16299 -> 22621) instead of removed. On a host without 10.0.22621.0 installed (this dev box has 10.0.26100.0 only), ARM64 builds of any non-UWP project (e.g., stubdata.vcxproj as a dependency of common_uwp) fail with MSB8036. Remove the 4 hardcoded lines so ARM/ARM64 inherit the same dynamic-SDK behavior as x86/x64. Keep all other ARM/ARM64-specific configuration: output dirs, preprocessor defines, TargetMachine, kernel32.lib, the WindowsSDKDesktopARMSupport / WindowsSDKDesktopARM64Support flags. ARM32 (Platform=ARM) is not in the build matrix iterated by upgrade-ver/icu/build-test.ps1 (lines 138-142 only enumerate Win32/x64/ARM64), so dropping the ARM32 SDK pinning has no impact on our supported configurations. Verified by independent gpt-5.5 DA pass; cited primary sources: - source\stubdata\stubdata.vcxproj:11-16 - source\allinone\Build.Windows.ProjectConfiguration.props:61-72,185-188,201-204 - source\allinone\Build.Windows.PlatformToolset.props:32-43 - source\allinone\allinone.sln:13-15,186-188 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Repair the icu4c LICENSE symlink so releaseDist can install the license from the repo layout. Move the ARM64 Linux build image to Ubuntu 18.04 so clang++-9 has C++17 standard library support for ICU 78 string_view headers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a root CodeQL.yml so 1ES CodeQL treats imported upstream ICU sources as library code while keeping MSFT-owned patches and build scripts visible. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the root 1ES-style CodeQL.yml with GitHub's .github/codeql/codeql-config.yml so CodeQL can ignore imported upstream ICU source and test data. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rp9-next
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 6 of the ICU 78 update split.
This PR is stacked on top of the previous part and contains build, CI, CodeQL, and repository plumbing updates needed for the ICU 78 split.
It keeps the remaining Microsoft-edited changes separated from the upstream dump and generated-data PRs.
Source commits from the abandoned combined PR: df442ac, 7551e0e, b9cfc00, bc9b0ae, 56917e0.