Update ICU to 78 - Part 5: patch records and dev report#186
Open
aoruganti-msft wants to merge 4 commits into
Open
Update ICU to 78 - Part 5: patch records and dev report#186aoruganti-msft wants to merge 4 commits into
aoruganti-msft wants to merge 4 commits into
Conversation
Refresh the stale/corrupt MSFT patch records for the ICU 78 upgrade: re-derived test expectations, final string-store size, uprefs refresh, and LF-only checkout rules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add the generated development review report for the ICU 78 / CLDR 48 upgrade. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add patch 023 to record the ar-SA SAR symbol override and its regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Record patch 023 and the targeted validation for the ar-SA SAR symbol override. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rp9-next
reviewed
May 23, 2026
| if (U_FAILURE(errorCode)) { | ||
| log_err("ulocdata_getPaperSize failed for locale %s with error: %s \n", currLoc, u_errorName(errorCode)); | ||
| } else { | ||
| + /* MSFT Change: CLDR-MS adds 029 region with US paper size */ |
Collaborator
There was a problem hiding this comment.
Older convention was to wrap any MSFT specific change around a comment,
I would still want to follow that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of the ICU 78 update split.
This PR is stacked on top of the previous part and contains patch record refreshes and ICU 78 development report updates.
It keeps the remaining Microsoft-edited changes separated from the upstream dump and generated-data PRs.
Source commits from the abandoned combined PR: aebb857, d24878f, 70ae0ef, 7484970.