C-WCOW: Enforce hashes on already mounted CIMs #2556
+127
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micromaomao
reviewed
Nov 17, 2025
MahatiC
force-pushed
the
enforce-hashes
branch
from
9994456 to
40ae7cb
Compare
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
MahatiC
force-pushed
the
enforce-hashes
branch
from
40ae7cb to
b606172
Compare
anmaxvl
reviewed
Jan 14, 2026
| containerID, settings.CombinedLayers.ContainerRootPath, settings.CombinedLayers.Layers, settings.CombinedLayers.ScratchPath) | ||
|
|
||
| // The layers size is only one, this is just defensive checking | ||
| if len(settings.CombinedLayers.Layers) == 1 { |
Contributor
There was a problem hiding this comment.
feels like we should do something if it's not 1? The request is coming from the host, so this can be set to anything?
Contributor
There was a problem hiding this comment.
also, consider reducing the nested ifs, by returning error early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, Security policy verification of CIM layers (via
EnforceVerifiedCIMsPolicy) occurred only during theResourceTypeWCOWBlockCimstype request. When a new container reused an already-mounted merged block CIM, it did not issue a newResourceTypeWCOWBlockCimstype request and therefore it wouldn't get recorded in the policy metadata. This PR will fix that and will enforce the CIMs on all containers including the ones that have the CIMs mounted already.