Isolated layerextract #1399
Draft
Isolated layerextract #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
force-pushed
the
he/layerextract
branch
4 times, most recently
from
18f5ba7 to
25aa0aa
Compare
Contributor
|
Oh shoot. Whats the plan for this in containerd integrations? Interesting hack to add the re-exec on the differ itself. |
Contributor
Author
I didnt know of another way to reduce privileges and isolate the extraction/conversion. |
Contributor
|
Just linked the containerd thread on this for ya. We for sure want this in upstream |
Created binary stream processors to extract tar layers and then convert to a VHD for LCOW or WCOW (via tar2ext4.Convert or ociwclayer.ImportLayerFromTar, respectively). Currently, binary re-execs itself using a restricted token with limited privileges and reduced access. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
he/layerextract
branch
2 times, most recently
from
072eacd to
f2e2b95
Compare
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
restricted SIDs on restricted token now work Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new binary (
cmd/differ) that functions as a binary stream processor for containerd differ plugins.The command can extract tars and run both
tar2ext4orwclayer.extractfor LCOW and WCOW images, respectively.