Expiry date search parameter

[LTA-Thinking]

Description

Adds a built in search parameter for the expiry date extension.

Related issues

Addresses User Story 183519

Testing

Describe how this change was tested.

FHIR Team Checklist

• Update the title of the PR to be succinct and less than 65 characters
• Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
• Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
• Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
• Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
• When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
• CI is green before merge
• Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

In general, to fix redundant ToString() calls in interpolated or concatenated strings, remove the explicit .ToString() when the language/runtime will implicitly convert the value to string anyway (such as in $"..." or string.Format). This keeps the code simpler and avoids unnecessary method calls.

In this specific case, within InitializeSearchParameterStatuses in SqlServerFhirModel.cs, line 397 builds a SQL command via an interpolated verbatim string. It uses '{SearchParameterStatus.Enabled.ToString()}' and '{SearchParameterStatus.Supported.ToString()}' inside the command text. C# interpolated strings automatically call ToString() on SearchParameterStatus.Enabled and SearchParameterStatus.Supported, so the explicit .ToString() calls are redundant. The correct fix is to remove .ToString() from both occurrences on that line, leaving '{SearchParameterStatus.Enabled}' and '{SearchParameterStatus.Supported}'. No other imports, methods, or definitions are needed, and the resulting SQL text will be identical to the current one.

Concretely:

• Edit src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirModel.cs.
• In the sqlCommandWrapper.CommandText assignment, on the UPDATE dbo.SearchParam line, replace SearchParameterStatus.Enabled.ToString() with SearchParameterStatus.Enabled and SearchParameterStatus.Supported.ToString() with SearchParameterStatus.Supported.
• Leave all other code unchanged.

---

In general, to fix redundant ToString() calls in interpolated strings or string concatenations, you should remove the explicit .ToString() and let C#’s implicit conversion (via string.Format or interpolation) invoke ToString() as needed. This avoids unnecessary method calls and cleans up the code without altering behavior.

In this specific method, InitializeSearchParameterStatuses, the SQL command text is built with an interpolated verbatim string assigned to sqlCommandWrapper.CommandText. Line 397 contains two explicit ToString() calls: SearchParameterStatus.Enabled.ToString() and SearchParameterStatus.Supported.ToString(). These appear inside {...} interpolation holes, so the compiler will already call ToString() on those values. We can safely remove both .ToString() calls and interpolate SearchParameterStatus.Enabled and SearchParameterStatus.Supported directly. No additional imports, methods, or definitions are needed; only this line in SqlServerFhirModel.cs must be updated.

Concretely, update line 397 from:

SET Status = CASE WHEN sps.Status = '{SearchParameterStatus.Enabled.ToString()}' THEN (CASE WHEN @resourcesPresent = 1 THEN '{SearchParameterStatus.Supported.ToString()}' ELSE sps.Status END) ELSE sps.Status END

to:

SET Status = CASE WHEN sps.Status = '{SearchParameterStatus.Enabled}' THEN (CASE WHEN @resourcesPresent = 1 THEN '{SearchParameterStatus.Supported}' ELSE sps.Status END) ELSE sps.Status END

This preserves the generated SQL while removing redundant ToString() calls.