Skip to content

Devirtualization + internal linkage: mark leaf impl classes final and TU-local helpers static #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmehta001 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Devirtualization + internal linkage: mark leaf impl classes final and TU-local helpers static #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d12da4
devirt: mark concrete leaf impl classes final
bmehta001 Jun 18, 2026
d0c0afb
Internal linkage: mark TU-local C-API helpers and DllMain global static
bmehta001 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/api/capi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ capi_client * MAT::capi_get_client(evt_handle_t handle)
/// <summary>
/// Remove C API handle from active client tracking struct.
/// </summary>
void remove_client(evt_handle_t handle)
static void remove_client(evt_handle_t handle)
{
LOCKGUARD(mtx);
clients.erase(handle);
Expand All @@ -66,7 +66,7 @@ void remove_client(evt_handle_t handle)
return ENOENT; \
};

evt_status_t mat_open_core(
static evt_status_t mat_open_core(
evt_context_t *ctx,
const char* config,
http_send_fn_t httpSendFn,
Expand Down Expand Up @@ -175,7 +175,7 @@ evt_status_t mat_open_core(
return ctx->result;
}

evt_status_t mat_open(evt_context_t *ctx)
static evt_status_t mat_open(evt_context_t *ctx)
{
if (ctx == nullptr)
{
Expand All @@ -186,7 +186,7 @@ evt_status_t mat_open(evt_context_t *ctx)
return mat_open_core(ctx, config, nullptr, nullptr, nullptr, nullptr, nullptr);
}

evt_status_t mat_open_with_params(evt_context_t *ctx)
static evt_status_t mat_open_with_params(evt_context_t *ctx)
{
if (ctx == nullptr)
{
Expand Down Expand Up @@ -233,7 +233,7 @@ evt_status_t mat_open_with_params(evt_context_t *ctx)
/**
* Marashal C struct to C++ API
*/
evt_status_t mat_log(evt_context_t *ctx)
static evt_status_t mat_log(evt_context_t *ctx)
Comment on lines 233 to +236
{
VERIFY_CLIENT_HANDLE(client, ctx);

Expand Down Expand Up @@ -285,7 +285,7 @@ evt_status_t mat_log(evt_context_t *ctx)
return ctx->result;
}

evt_status_t mat_close(evt_context_t *ctx)
static evt_status_t mat_close(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(LogManagerProvider::Release(client->logmanager->GetLogConfiguration()));
Expand All @@ -305,31 +305,31 @@ evt_status_t mat_close(evt_context_t *ctx)
return result;
}

evt_status_t mat_pause(evt_context_t *ctx)
static evt_status_t mat_pause(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(client->logmanager->PauseTransmission());
ctx->result = result;
return result;
}

evt_status_t mat_resume(evt_context_t *ctx)
static evt_status_t mat_resume(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(client->logmanager->ResumeTransmission());
ctx->result = result;
return result;
}

evt_status_t mat_upload(evt_context_t *ctx)
static evt_status_t mat_upload(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
const auto result = static_cast<evt_status_t>(client->logmanager->UploadNow());
ctx->result = result;
return result;
}

evt_status_t mat_flushAndTeardown(evt_context_t *ctx)
static evt_status_t mat_flushAndTeardown(evt_context_t *ctx)
{
VERIFY_CLIENT_HANDLE(client, ctx);
client->logmanager->FlushAndTeardown();
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClient_Android.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

namespace MAT_NS_BEGIN
{
class HttpClient_Android : public IHttpClient
class HttpClient_Android final : public IHttpClient
{
enum class RequestState : int8_t
{
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClient_Apple.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace MAT_NS_BEGIN {

class HttpClient_Apple : public IHttpClient {
class HttpClient_Apple final : public IHttpClient {
public:
HttpClient_Apple();
virtual ~HttpClient_Apple() noexcept;
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClient_CAPI.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace MAT_NS_BEGIN {

class HttpClient_CAPI : public IHttpClient {
class HttpClient_CAPI final : public IHttpClient {
public:
HttpClient_CAPI(http_send_fn_t sendFn, http_cancel_fn_t cancelFn);

Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClient_Curl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace MAT_NS_BEGIN {
/**
* Curl-based HTTP client
*/
class HttpClient_Curl : public IHttpClient {
class HttpClient_Curl final : public IHttpClient {
public:
HttpClient_Curl();
virtual ~HttpClient_Curl();
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClient_WinInet.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ typedef void* HINTERNET;

class WinInetRequestWrapper;

class HttpClient_WinInet : public IHttpClient {
class HttpClient_WinInet final : public IHttpClient {
public:
// Common IHttpClient methods
HttpClient_WinInet();
Expand Down
2 changes: 1 addition & 1 deletion lib/http/HttpClient_WinRt.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace MAT_NS_BEGIN {

class WinRtRequestWrapper;

class HttpClient_WinRt : public IHttpClient {
class HttpClient_WinRt final : public IHttpClient {
public:
HttpClient_WinRt();
virtual ~HttpClient_WinRt();
Expand Down
2 changes: 1 addition & 1 deletion lib/offline/MemoryStorage.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

namespace MAT_NS_BEGIN {

class MemoryStorage : public IOfflineStorage
class MemoryStorage final : public IOfflineStorage
{

public:
Expand Down
2 changes: 1 addition & 1 deletion lib/offline/OfflineStorageHandler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace MAT_NS_BEGIN {

class OfflineStorageHandler : public IOfflineStorage, public IOfflineStorageObserver
class OfflineStorageHandler final : public IOfflineStorage, public IOfflineStorageObserver
{
public:
OfflineStorageHandler(ILogManager& logManager, IRuntimeConfig& runtimeConfig, ITaskDispatcher& taskDispatcher);
Expand Down
2 changes: 1 addition & 1 deletion lib/offline/OfflineStorage_Room.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace MAT_NS_BEGIN
{
class OfflineStorage_Room : public IOfflineStorage
class OfflineStorage_Room final : public IOfflineStorage
{
protected:
class ConnectedEnv
Expand Down
2 changes: 1 addition & 1 deletion lib/shared/dllmain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#ifdef _MANAGED
#pragma unmanaged
#endif
unsigned thread_count = 0;
static unsigned thread_count = 0;

BOOL APIENTRY DllMain(HMODULE /* hModule */, DWORD ul_reason_for_call, LPVOID /* lpReserved */)
{
Expand Down
Loading