Skip to content

Fix -Wextra-semi errors in LogManagerBase.hpp #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmehta001 merged 6 commits into from
Jun 10, 2026
Merged

Fix -Wextra-semi errors in LogManagerBase.hpp #1471

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e78f68
Fix -Wextra-semi errors in LogManagerBase.hpp public header
bmehta001 Jun 10, 2026
9ad125f
LogManagerBase: address Copilot round-1 - delete copy operations
bmehta001 Jun 10, 2026
99b0e0f
LogManagerBase: address Copilot round-2 - well-formed no-op copy ops
bmehta001 Jun 10, 2026
53d0a87
LogManagerBase: address Copilot round-3 - make non-copyable explicit …
bmehta001 Jun 10, 2026
93fd52a
LogManagerBase: address Copilot round-4 - scope to -Wextra-semi only
bmehta001 Jun 10, 2026
27a5733
Merge branch 'main' into bhamehta/logmanagerbase-extra-semi
bmehta001 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions lib/include/public/LogManagerBase.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,22 +132,22 @@ namespace MAT_NS_BEGIN
/// <summary>
/// LogManagerBase constructor
/// </summary>
LogManagerBase(){};
LogManagerBase(){}

/// <summary>
/// LogManager copy constructor
/// </summary>
LogManagerBase(const LogManagerBase&){};
LogManagerBase(const LogManagerBase&){}

/// <summary>
/// [not implemented] LogManager assignment operator
/// </summary>
LogManagerBase& operator=(const LogManagerBase&){};
LogManagerBase& operator=(const LogManagerBase&){}

/// <summary>
/// LogManager destructor
/// </summary>
virtual ~LogManagerBase(){};
virtual ~LogManagerBase(){}

#ifndef _MANAGED
/// <summary>
Expand Down Expand Up @@ -418,7 +418,7 @@ namespace MAT_NS_BEGIN
/// <summary>Get profile name based on built-in profile enum<summary>
/// <param name="profile">Transmit profile</param>
static std::string GetTransmitProfileName()
LM_SAFE_CALL_STR(GetTransmitProfileName);
LM_SAFE_CALL_STR(GetTransmitProfileName)

/// <summary>
/// Retrieve an ISemanticContext interface through which to specify context information
Expand All @@ -428,7 +428,7 @@ namespace MAT_NS_BEGIN
/// </summary>
/// <returns>ISemanticContext interface pointer</returns>
static ISemanticContext* GetSemanticContext()
LM_SAFE_CALL_PTRREF(GetSemanticContext);
LM_SAFE_CALL_PTRREF(GetSemanticContext)

/// <summary>
/// Adds or overrides a property of the custom context for the telemetry logging system.
Expand All @@ -439,7 +439,7 @@ namespace MAT_NS_BEGIN
/// <param name="value">Value of the context property</param>
/// <param name='piiKind'>PIIKind of the context with PiiKind_None as the default</param>
static status_t SetContext(const std::string& name, const std::string& value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, value, piiKind);
LM_SAFE_CALL(SetContext, name, value, piiKind)

/// <summary>
/// Adds or overrides a property of the custom context for the telemetry logging system.
Expand All @@ -450,23 +450,23 @@ namespace MAT_NS_BEGIN
/// <param name="value">Value of the context property</param>
/// <param name='piiKind'>PIIKind of the context with PiiKind_None as the default</param>
static status_t SetContext(const std::string& name, const char* value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, std::string(value), piiKind);
LM_SAFE_CALL(SetContext, name, std::string(value), piiKind)

/// <summary>
/// Adds or overrides a property of the global context.
/// </summary>
/// <param name="name">Name of the property</param>
/// <param name="value">Double value of the property</param>
static status_t SetContext(const std::string& name, double value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, value, piiKind);
LM_SAFE_CALL(SetContext, name, value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.
/// </summary>
/// <param name="name">Name of the property</param>
/// <param name="value">64-bit Integer value of the property</param>
static status_t SetContext(const std::string& name, int64_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, value, piiKind);
LM_SAFE_CALL(SetContext, name, value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.<br>
Expand All @@ -475,7 +475,7 @@ namespace MAT_NS_BEGIN
/// <param name="name">Name of the property</param>
/// <param name="value">8-bit Integer value of the property</param>
static status_t SetContext(const std::string& name, int8_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind);
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.<br>
Expand All @@ -484,7 +484,7 @@ namespace MAT_NS_BEGIN
/// <param name="name">Name of the property</param>
/// <param name="value">16-bit Integer value of the property</param>
static status_t SetContext(const std::string& name, int16_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind);
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.<br>
Expand All @@ -493,7 +493,7 @@ namespace MAT_NS_BEGIN
/// <param name="name">Name of the property</param>
/// <param name="value">32-bit Integer value of the property</param>
static status_t SetContext(const std::string& name, int32_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind);
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.<br>
Expand All @@ -502,7 +502,7 @@ namespace MAT_NS_BEGIN
/// <param name="name">Name of the property</param>
/// <param name="value">8-bit unsigned integer value of the property</param>
static status_t SetContext(const std::string& name, uint8_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind);
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.<br>
Expand All @@ -511,7 +511,7 @@ namespace MAT_NS_BEGIN
/// <param name="name">Name of the property</param>
/// <param name="value">16-bit unsigned integer value of the property</param>
static status_t SetContext(const std::string& name, uint16_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind);
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.<br>
Expand All @@ -520,7 +520,7 @@ namespace MAT_NS_BEGIN
/// <param name="name">Name of the property</param>
/// <param name="value">32-bit unsigned integer value of the property</param>
static status_t SetContext(const std::string& name, uint32_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind);
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.<br>
Expand All @@ -529,46 +529,46 @@ namespace MAT_NS_BEGIN
/// <param name="name">Name of the property</param>
/// <param name="value">64-bit unsigned integer value of the property</param>
static status_t SetContext(const std::string& name, uint64_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind);
LM_SAFE_CALL(SetContext, name, (int64_t)value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.
/// </summary>
/// <param name="name">Name of the property</param>
/// <param name="value">Boolean value of the property</param>
static status_t SetContext(const std::string& name, bool value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, value, piiKind);
LM_SAFE_CALL(SetContext, name, value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.
/// </summary>
/// <param name="name">Name of the property</param>
/// <param name="value">.NET time ticks</param>
static status_t SetContext(const std::string& name, time_ticks_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, value, piiKind);
LM_SAFE_CALL(SetContext, name, value, piiKind)

/// <summary>
/// Adds or overrides a property of the global context.
/// </summary>
/// <param name="name">Name of the property</param>
/// <param name="value">GUID</param>
static status_t SetContext(const std::string& name, GUID_t value, PiiKind piiKind = PiiKind_None)
LM_SAFE_CALL(SetContext, name, value, piiKind);
LM_SAFE_CALL(SetContext, name, value, piiKind)

/// <summary>
/// Retrieves the ILogger interface of a Logger instance through which to log telemetry event.
/// </summary>
/// <returns>Pointer to the Ilogger interface of an logger instance</returns>
static ILogger* GetLogger()
LM_SAFE_CALL_PTR(GetLogger, GetPrimaryToken());
LM_SAFE_CALL_PTR(GetLogger, GetPrimaryToken())

/// <summary>
/// Retrieves the ILogger interface of a Logger instance through which to log telemetry event.
/// </summary>
/// <param name="source">Source name of events sent by this logger instance</param>
/// <returns>Pointer to the Ilogger interface of the logger instance</returns>
static ILogger* GetLogger(const std::string& source)
LM_SAFE_CALL_PTR(GetLogger, GetPrimaryToken(), source);
LM_SAFE_CALL_PTR(GetLogger, GetPrimaryToken(), source)

/// <summary>
/// Retrieves the ILogger interface of a Logger instance through which to log telemetry event.
Expand All @@ -577,13 +577,13 @@ namespace MAT_NS_BEGIN
/// <param name="source">Source name of events sent by this logger instance</param>
/// <returns>Pointer to the Ilogger interface of the logger instance</returns>
static ILogger* GetLogger(const std::string& tenantToken, const std::string& source)
LM_SAFE_CALL_PTR(GetLogger, tenantToken, source);
LM_SAFE_CALL_PTR(GetLogger, tenantToken, source)

/// <summary>
/// Get Auth token controller
/// </summary>
static IAuthTokensController* GetAuthTokensController()
LM_SAFE_CALL_PTR(GetAuthTokensController);
LM_SAFE_CALL_PTR(GetAuthTokensController)

/// <summary>
///Sets the ticket token with a value
Expand Down Expand Up @@ -653,7 +653,7 @@ namespace MAT_NS_BEGIN
/// </summary>
/// <returns>The log session data in a pointer to a LogSessionData object.</returns>
static LogSessionData* GetLogSessionData()
LM_SAFE_CALL_PTR(GetLogSessionData);
LM_SAFE_CALL_PTR(GetLogSessionData)

/// <summary>
/// Sets the diagnostic level filter for the LogManager
Expand All @@ -662,15 +662,15 @@ namespace MAT_NS_BEGIN
/// <param name="levelMin">Minimum level to be sent</param>
/// <param name="levelMin">Maximum level to be sent</param>
static void SetLevelFilter(uint8_t defaultLevel, uint8_t levelMin, uint8_t levelMax)
LM_SAFE_CALL_VOID(SetLevelFilter, defaultLevel, levelMin, levelMax);
LM_SAFE_CALL_VOID(SetLevelFilter, defaultLevel, levelMin, levelMax)

/// <summary>
/// Sets the diagnostic level filter for the LogManager
/// </summary>
/// <param name="defaultLevel">Diagnostic level for the LogManager</param>
/// <param name="allowedLevels">Set with levels that are allowed to be sent</param>
static void SetLevelFilter(uint8_t defaultLevel, const std::set<uint8_t>& allowedLevels)
LM_SAFE_CALL_VOID(SetLevelFilter, defaultLevel, allowedLevels);
LM_SAFE_CALL_VOID(SetLevelFilter, defaultLevel, allowedLevels)

static ILogController* GetController()
{
Expand All @@ -686,7 +686,7 @@ namespace MAT_NS_BEGIN
/// Reserved for future use to notify SDK about ILogConfiguration & contents change.
/// </summary>
static status_t Configure()
LM_SAFE_CALL(Configure);
LM_SAFE_CALL(Configure)

/// <summary>
/// Obtain data viewer collection associated with this LogManager instance.
Expand Down
Loading