use `find_packages` in cmake files to for shared lib build by yulin-li · Pull Request #1084 · microsoft/cpp_client_telemetry

yulin-li · 2023-01-13T09:10:23Z

No description provided.

lalitb · 2023-01-20T23:12:51Z

@yulin-li The build script already supports building shared library for 1ds as here.

So, something like this should work:

$ export CMAKE_OPTS='-DBUILD_SHARED_LIBS=ON'
$ ./build-tests.sh release

yulin-li · 2023-01-21T08:19:40Z

@yulin-li The build script already supports building shared library for 1ds as here.

So, something like this should work:
$ export CMAKE_OPTS='-DBUILD_SHARED_LIBS=ON'
$ ./build-tests.sh release

oh thanks, let me revert the changes in build-test.sh. I think it's still worth to keep the find_package updates.

lalitb · 2023-01-23T19:22:14Z

oh thanks, let me revert the changes in build-test.sh. I think it's still worth to keep the find_package updates.

This would be a problem if we install sqlite3 from (say) apt package manager. As "sqlite3" or "sqlite3-dev" package installed through it doesn't seem to include a CMake package config file. Do you see issue without find_package, as the build will eventually fail anyway if sqlite3 is not installed ?

# dpkg-query -L  libsqlite3-dev:amd64
/.
/usr
/usr/include
/usr/include/sqlite3.h
/usr/include/sqlite3ext.h
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libsqlite3.a
/usr/lib/x86_64-linux-gnu/libsqlite3.la
/usr/lib/x86_64-linux-gnu/pkgconfig
/usr/lib/x86_64-linux-gnu/pkgconfig/sqlite3.pc
/usr/share
/usr/share/doc
/usr/share/doc/libsqlite3-dev
/usr/share/doc/libsqlite3-dev/copyright
/usr/lib/x86_64-linux-gnu/libsqlite3.so
/usr/share/doc/libsqlite3-dev/changelog.Debian.gz

# dpkg-query -L   libsqlite3-0:amd64
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libsqlite3.so.0.8.6
/usr/share
/usr/share/doc
/usr/share/doc/libsqlite3-0
/usr/share/doc/libsqlite3-0/README.Debian
/usr/share/doc/libsqlite3-0/changelog.Debian.gz
/usr/share/doc/libsqlite3-0/copyright
/usr/lib/x86_64-linux-gnu/libsqlite3.so.0

# dpkg-query -L sqlite3
/.
/usr
/usr/bin
/usr/bin/sqldiff
/usr/bin/sqlite3
/usr/share
/usr/share/doc
/usr/share/doc/sqlite3
/usr/share/doc/sqlite3/copyright
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/sqldiff.1.gz
/usr/share/man/man1/sqlite3.1.gz
/usr/share/doc/sqlite3/changelog.Debian.gz

lalitb · 2023-01-31T07:05:11Z

@yulin-li - let us know if the PR is still valid ?

yulin-li · 2024-03-03T05:28:04Z

CMAKE_OPTS='-DBUILD_SHARED_LIBS=ON'

sorry for this very late reply. The camke configurations is actually provided by cmake (https://github.com/Kitware/CMake/blob/master/Modules/FindSQLite3.cmake), not sqlite3 package.

The problem without find_packages is, we cannot use sqlite3 installed by package managers, we need to install a duplicated one in /usr/local/lib/

yulin-li · 2024-03-03T05:29:32Z

**lalitb ** c

@lalitb this PR is still valid, which allows us to use sqlite3 libs installed by package managers.

yulin-li · 2024-05-30T01:51:04Z

@ThomsonTan I saw you were updating this PR. Could it be reviewed and merge? So we can avoid patching it in our project.

ThomsonTan · 2024-08-14T22:18:34Z

@yulin-li, is this PR still valid? Does the consuming of local install sqlite3 break other users who may not epect the local install?

yulin-li · 2024-08-15T08:08:45Z

@yulin-li, is this PR still valid? Does the consuming of local install sqlite3 break other users who may not epect the local install?

This is still valid. The local sqlite is only required if the user wants to build a shared lib. This won't change the behavior for static lib build.

ThomsonTan · 2024-09-24T16:52:18Z

    add_library(sqlite3 SHARED IMPORTED GLOBAL)
    add_library(z SHARED IMPORTED GLOBAL)
-    target_link_libraries(mat PUBLIC sqlite3 PUBLIC z ${LIBS} "${CMAKE_THREAD_LIBS_INIT}" "${CMAKE_DL_LIBS}" "${CMAKE_REQUIRED_LIBRARIES}")
+    find_package(SQLite3 REQUIRED)


find_package(SQLite3 REQUIRED)

Is there any scenario where the call to find_package(SQLite3 REQUIRED) is required? Assume the current hard-coded name still works, right?

yes, the current hard-coded name still works. But I think the find_package is a preferred way by cmake, and it will report a clearer error if sqlite3 is not installed

into yulin/shared-lib

CMake 4.0 removed compatibility with cmake_minimum_required < 3.5, which broke configuration of this repo: wrappers/obj-c/CMakeLists.txt still declared 2.8.2. Normalize every repo-owned CMakeLists.txt to the range 3.15...3.31 so the project both configures under CMake 4.x and pins a predictable policy ceiling. 3.15 is the floor because the built-in FindSQLite3 module (used below) requires >= 3.14, and several existing files already required 3.15. Subsume #1084: in the legacy (non-vcpkg) Linux/macOS dependency path, replace the bare "sqlite3" link name with find_package(SQLite3 REQUIRED) and the imported SQLite::SQLite3 target, which carries its own include directories. Applied in lib, functests, and unittests; the static-.a fallbacks and the vcpkg/Android/Windows paths are unchanged. Vendored zlib CMakeLists are left untouched (already >= 3.5). Validated: - CMake 4.3.3 rejects the old 2.8.2 floor and accepts 3.15...3.31. - Repo root configures cleanly under CMake 4.3.3 (Windows, vcpkg deps). - find_package(SQLite3 REQUIRED) + SQLite::SQLite3 resolves on Linux. Files: CMakeLists.txt; 6 examples/*/CMakeLists.txt; lib/CMakeLists.txt; lib/android_build/{app,maesdk}/src/main/cpp/CMakeLists.txt; tests/{vcpkg,functests,unittests}/CMakeLists.txt; wrappers/{obj-c,swift}/CMakeLists.txt Resolves #1339. Supersedes #1084. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bmehta001 · 2026-06-17T00:47:06Z

Thanks, @yulin-li, for contributing this PR. I have since made some efforts to improve the CMake/build files and am now using find_packages for all packages, including SQLite, as of #1478 as well, so this PR has been subsumed. Closing. Please let me know if you have any questions.

update scripts/cmake files to imporve shared lib build propcess

c7050c6

yulin-li requested review from bliptec, kindbe, lalitb, maxgolov, mkoscumb, reyang and sid-dahiya as code owners January 13, 2023 09:10

Yulin Li added 2 commits January 21, 2023 16:21

revert

673c5ca

revert

e8389d7

yulin-li changed the title ~~update scripts/cmake files to imporve shared lib build propcess~~ use find_packages in cmake files to for shared lib build Jan 21, 2023

Merge branch 'main' into yulin/shared-lib

7fd2e70

Merge branch 'main' into yulin/shared-lib

7ea8ce7

yulin-li requested a review from a team as a code owner March 3, 2024 05:23

ThomsonTan added 4 commits May 22, 2024 20:29

Merge branch 'main' into yulin/shared-lib

1aa817a

Merge branch 'main' into yulin/shared-lib

7dafe30

Merge branch 'main' into yulin/shared-lib

eeb0f06

Merge branch 'main' into yulin/shared-lib

5daf8e7

yulin-li added 2 commits August 15, 2024 16:08

Merge branch 'main' into yulin/shared-lib

3f2e4c8

Merge branch 'main' into yulin/shared-lib

04f09a2

ThomsonTan reviewed Sep 24, 2024

View reviewed changes

yulin-li and others added 2 commits October 12, 2024 15:05

Merge branch 'main' into yulin/shared-lib

a911a36

Merge branch 'main' of https://github.com/microsoft/cpp_client_telemetry

022d7ad

into yulin/shared-lib

bmehta001 mentioned this pull request Jun 11, 2026

Raise CMake floor to 3.15...3.31 and use find_package(SQLite3) (subsumes #1084) #1478

Merged

bmehta001 closed this Jun 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use `find_packages` in cmake files to for shared lib build#1084

use `find_packages` in cmake files to for shared lib build#1084
yulin-li wants to merge 13 commits into
mainfrom
yulin/shared-lib

yulin-li commented Jan 13, 2023 •

edited

Loading

Uh oh!

lalitb commented Jan 20, 2023 •

edited

Loading

Uh oh!

yulin-li commented Jan 21, 2023

Uh oh!

lalitb commented Jan 23, 2023 •

edited

Loading

Uh oh!

lalitb commented Jan 31, 2023

Uh oh!

yulin-li commented Mar 3, 2024

Uh oh!

yulin-li commented Mar 3, 2024

Uh oh!

yulin-li commented May 30, 2024

Uh oh!

ThomsonTan commented Aug 14, 2024

Uh oh!

yulin-li commented Aug 15, 2024

Uh oh!

ThomsonTan Sep 24, 2024

Uh oh!

yulin-li Sep 25, 2024

Uh oh!

bmehta001 commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

yulin-li commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lalitb commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yulin-li commented Jan 21, 2023

Uh oh!

lalitb commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lalitb commented Jan 31, 2023

Uh oh!

yulin-li commented Mar 3, 2024

Uh oh!

yulin-li commented Mar 3, 2024

Uh oh!

yulin-li commented May 30, 2024

Uh oh!

ThomsonTan commented Aug 14, 2024

Uh oh!

yulin-li commented Aug 15, 2024

Uh oh!

ThomsonTan Sep 24, 2024

Choose a reason for hiding this comment

Uh oh!

yulin-li Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

bmehta001 commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yulin-li commented Jan 13, 2023 •

edited

Loading

lalitb commented Jan 20, 2023 •

edited

Loading

lalitb commented Jan 23, 2023 •

edited

Loading