Add command result support for resource commands#15622
Draft
Add command result support for resource commands#15622
Conversation
Add Result and ResultFormat properties to ExecuteCommandResult, allowing resource commands to return structured output data (text or JSON). Thread result data through the entire pipeline: - Model: CommandResultFormat enum (None/Text/Json), Result property - Proto/gRPC: result and result_format fields in ResourceCommandResponse - Backchannel: Result/ResultFormat in ExecuteResourceCommandResponse - Dashboard: TextVisualizerDialog for command results - CLI: Display result with Spectre markup escaping - MCP: Return result as additional TextContentBlock Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15622Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15622" |
Demonstrates the command result feature by generating a fake JWT token and returning it as JSON via CommandResults.Success(json, CommandResultFormat.Json). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23598798536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ResultandResultFormatproperties toExecuteCommandResult, allowing resource commands to return structured output data (text or JSON) back to the caller.Part of #15610
Changes
Model
CommandResultFormatenum:None,Text,JsonExecuteCommandResultgainsResult(string?) andResultFormatpropertiesCommandResults.Success(result, format)overload for producing resultsProto/gRPC
ResourceCommandResponsegetsoptional string resultandCommandResultFormat result_formatfieldsBackchannel
ExecuteResourceCommandResponsegainsResultandResultFormat(string) propertiesAuxiliaryBackchannelRpcTargetDashboard
ResourceCommandResponseViewModelgainsResultandCommandResultFormatTextVisualizerDialog(existing JSON/XML/text viewer with syntax highlighting)FixedFormatto lock the viewer to JSON modeCLI
[/]in JSON from being interpreted as markup)TextContentBlockReplica aggregation
Testing