Open
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15591Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15591" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the existing “startup-perf” tooling so Aspire startup performance measurement can be run on macOS/Linux (in addition to the existing Windows/PowerShell workflow), using dotnet-trace plus the existing TraceAnalyzer.
Changes:
- Added a new cross-platform Bash script to run the AppHost and collect/compute startup timing from traces.
- Updated the startup-perf skill documentation to include macOS/Linux prerequisites, usage examples, and parameter mappings between PowerShell and Bash.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/perf/measure-startup-performance.sh | New Bash implementation for collecting startup traces and extracting DcpModelCreation duration. |
| .github/skills/startup-perf/SKILL.md | Documentation updates to describe and demonstrate macOS/Linux usage alongside Windows. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JamesNK
approved these changes
Mar 26, 2026
Member
|
I don't have Linux/macOS to test. I assume you've tested it works correctly. |
Contributor
|
🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23567526469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Totally vibe-coded... but works 😄