Skip to content

Prevent restarting haptic playback from gamepad/keyboard while a clip plays #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomaabe wants to merge 1 commit into from
Closed

Prevent restarting haptic playback from gamepad/keyboard while a clip plays #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions Samples/System/Haptics/haptics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,16 +202,31 @@ void Sample_Draw(float uiScale)

ImGui::Dummy(ImVec2(0, 20));

ImGui::BeginDisabled(hapticsDevice->IsPlaying());
if(ImGui::Button("Play WASAPI (L1)", ImVec2(160*uiScale, 50*uiScale)) || IsButtonPressed(state.buttons, context.lastGamepadState.buttons, GameInputGamepadButtons::GameInputGamepadLeftShoulder))
const bool isPlaying = hapticsDevice->IsPlaying();

ImGui::BeginDisabled(isPlaying);
// Always draw the buttons (ImGui requires the call every frame), but gate the
// resulting action on !isPlaying. ImGui::BeginDisabled only blocks new mouse/Tab
// focus; it does NOT block keyboard Space/Enter on an item that already had focus,
// and it does not affect the "|| IsButtonPressed(...)" gamepad shortcut at all.
// Gating the action closes both gaps so a clip cannot be restarted (or the other
// engine started) mid-play, and SetWindowFocus(nullptr) drops focus so the
// disabled button does not keep showing a pressed animation when Space is held.
const bool wasapiPressed = ImGui::Button("Play WASAPI (L1)", ImVec2(160*uiScale, 50*uiScale))
|| IsButtonPressed(state.buttons, context.lastGamepadState.buttons, GameInputGamepadButtons::GameInputGamepadLeftShoulder);
if(!isPlaying && wasapiPressed)
{
hapticsDevice->PlayWAVFile(context.mediaItem.filename.c_str(), HapticPlaybackEngine::WASAPI);
ImGui::SetWindowFocus(nullptr);
}
ImGui::SameLine();

if(ImGui::Button("Play XAudio2 (R1)", ImVec2(160*uiScale, 50*uiScale)) || IsButtonPressed(state.buttons, context.lastGamepadState.buttons, GameInputGamepadButtons::GameInputGamepadRightShoulder))
const bool xaudioPressed = ImGui::Button("Play XAudio2 (R1)", ImVec2(160*uiScale, 50*uiScale))
|| IsButtonPressed(state.buttons, context.lastGamepadState.buttons, GameInputGamepadButtons::GameInputGamepadRightShoulder);
if(!isPlaying && xaudioPressed)
{
hapticsDevice->PlayWAVFile(context.mediaItem.filename.c_str(), HapticPlaybackEngine::XAudio2);
ImGui::SetWindowFocus(nullptr);
}
ImGui::EndDisabled();

Expand Down