Skip to content

Conversation

@florelis
Copy link
Member

@florelis florelis commented Jan 1, 2026

The EventProvider was defined, but not included in the profile.

The EventProvider was defined, but not included in the profile.
@florelis florelis requested a review from a team as a code owner January 1, 2026 00:59
Copilot AI review requested due to automatic review settings January 1, 2026 00:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the wslaservice event provider to the WSL logging profile. The provider was previously defined in the file but was missing from the actual profile's EventProviders list, making it unavailable during ETL trace collection.

Key Changes

  • Added wslaservice EventProviderId to the WSL.Verbose.File profile's event provider list

Comment on lines +119 to 120
<EventProviderId Value="wslaservice"/>
<EventProviderId Value="wslapi"/>
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event provider should be placed after "wslapi" to maintain alphabetical ordering. The current placement between "wslclient" and "wslapi" breaks the alphabetical sequence that other providers follow (e.g., lxcore_kernel, lxcore_service, lxcore_user, wsl_devicehost). Move this line to appear after line 120 (wslapi).

Suggested change
<EventProviderId Value="wslaservice"/>
<EventProviderId Value="wslapi"/>
<EventProviderId Value="wslapi"/>
<EventProviderId Value="wslaservice"/>

Copilot uses AI. Check for mistakes.
@OneBlue OneBlue merged commit 48a349c into feature/wsl-for-apps Jan 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants