Skip to content

Use public version of nuget packages in AsyncCompletion sample #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmadeusW wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use public version of nuget packages in AsyncCompletion sample #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ce2c3c
Update to .net 4.7 and use publicly available Editor packages
AmadeusW Mar 2, 2020
745b0eb
Update the VSIX Manifest and package prerequisites
AmadeusW Mar 2, 2020
7f43e01
removes nuget.config
AmadeusW Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions AsyncCompletion/nuget.config
View file
Open in desktop

This file was deleted.

13 changes: 7 additions & 6 deletions AsyncCompletion/src/AsyncCompletionSample.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<UpgradeBackupLocation>
</UpgradeBackupLocation>
<OldToolsVersion>15.0</OldToolsVersion>
<TargetFrameworkProfile />
</PropertyGroup>
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
Expand All @@ -22,7 +23,7 @@
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>AsyncCompletionSample</RootNamespace>
<AssemblyName>AsyncCompletionSample</AssemblyName>
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
<TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
<GeneratePkgDefFile>false</GeneratePkgDefFile>
<IncludeAssemblyInVSIXContainer>true</IncludeAssemblyInVSIXContainer>
<IncludeDebugSymbolsInVSIXContainer>false</IncludeDebugSymbolsInVSIXContainer>
Expand Down Expand Up @@ -74,22 +75,22 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.CoreUtility">
<Version>16.0.127</Version>
<Version>16.0.467</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.Language">
<Version>16.0.127</Version>
<Version>16.0.467</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.SDK.Analyzers">
<Version>15.7.11</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.Text.Data">
<Version>16.0.127</Version>
<Version>16.0.467</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.Text.Logic">
<Version>16.0.127</Version>
<Version>16.0.467</Version>
</PackageReference>
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers">
<Version>15.7.21</Version>
<Version>15.8.192</Version>
</PackageReference>
<PackageReference Include="System.Collections.Immutable">
<Version>1.3.1</Version>
Expand Down
8 changes: 4 additions & 4 deletions AsyncCompletion/src/app.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<runtime>
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
<dependentAssembly>
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-9.0.0.0" newVersion="9.0.0.0" />
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-9.0.0.0" newVersion="9.0.0.0"/>
</dependentAssembly>
</assemblyBinding>
</runtime>
</configuration>
<startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7.2"/></startup></configuration>
8 changes: 4 additions & 4 deletions AsyncCompletion/src/source.extension.vsixmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
<Metadata>
<Identity Id="AsyncCompletionSample.3d0d76e1-7922-4a19-8ad5-8ec046f68783" Version="1.0" Language="en-US" Publisher="Amadeusz Wieczorek" />
<Identity Id="AsyncCompletionSample.3d0d76e1-7922-4a19-8ad5-8ec046f68783" Version="1.0" Language="en-US" Publisher="Microsoft" />
<DisplayName>AsyncCompletionSample</DisplayName>
<Description>Empty VSIX Project.</Description>
<Description xml:space="preserve">VSSDK AsyncCompletion sample</Description>
</Metadata>
<Installation>
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[15.0, 16.0)" />
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[16.0, 17.0)" />
</Installation>
<Dependencies>
<Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="[4.5,)" />
Expand All @@ -15,6 +15,6 @@
<Asset Type="Microsoft.VisualStudio.MefComponent" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%|" />
</Assets>
<Prerequisites>
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0,16.0)" DisplayName="Visual Studio core editor" />
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[16.0,17.0)" DisplayName="Visual Studio core editor" />
</Prerequisites>
</PackageManifest>