Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42740,6 +42740,22 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
);
}
}
// Also check if the type reference is an alias that is deprecated (e.g., ImportEqualsDeclaration with @deprecated)
if (node.kind !== SyntaxKind.ImportType) {
const name = getTypeReferenceName(node as TypeReferenceType);
if (name) {
const aliasSymbol = resolveEntityName(name, SymbolFlags.Type, /*ignoreErrors*/ true, /*dontResolveAlias*/ true);
if (aliasSymbol && aliasSymbol !== unknownSymbol && aliasSymbol !== symbol && aliasSymbol.flags & SymbolFlags.Alias) {
if (isDeprecatedSymbol(aliasSymbol) && aliasSymbol.declarations) {
addDeprecatedSuggestion(
getDeprecatedSuggestionNode(node),
aliasSymbol.declarations,
aliasSymbol.escapedName as string,
);
}
}
}
}
}
}

Expand Down
46 changes: 46 additions & 0 deletions tests/cases/fourslash/jsdocDeprecated_namespaceAlias.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/// <reference path="fourslash.ts" />

// @Filename: /example.ts
//// export type Bar = string | number;
//// /** @deprecated */
//// export type Baz = string | number;

// @Filename: /foo.ts
//// import * as example from './example';
////
//// export namespace JSX {
//// /** @deprecated */
//// export type Foo = string | number;
////
//// /** @deprecated */
//// export import Bar = example.Bar;
////
//// export import Baz = example.Baz;
//// }
////
//// export type X = JSX.[|Foo|]; // Should be deprecated (Foo itself is deprecated)
//// export type Y = JSX.[|Bar|]; // Should be deprecated (Bar alias is deprecated)
//// export type Z = JSX.[|Baz|]; // Should be deprecated (example.Baz is deprecated)

goTo.file('/foo.ts');
const ranges = test.ranges();
verify.getSuggestionDiagnostics([
{
"message": "'Foo' is deprecated.",
"code": 6385,
"range": ranges[0],
"reportsDeprecated": true,
},
{
"message": "'Bar' is deprecated.",
"code": 6385,
"range": ranges[1],
"reportsDeprecated": true,
},
{
"message": "'Baz' is deprecated.",
"code": 6385,
"range": ranges[2],
"reportsDeprecated": true,
},
]);